From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Sébastien Guimmara" <sebastien.guimmara@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH 3/5] generate-cmdlist: parse common group commands
Date: Thu, 14 May 2015 17:05:26 -0400 [thread overview]
Message-ID: <CAPig+cTrDd3eYXo1WPoWRk5XSuLyH_m_VU1JsnP8pjkM=n6O2Q@mail.gmail.com> (raw)
In-Reply-To: <xmqq617ukhal.fsf@gitster.dls.corp.google.com>
On Thu, May 14, 2015 at 4:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Sébastien Guimmara <sebastien.guimmara@gmail.com> writes:
>> From: Eric Sunshine <sunshine@sunshineco.com>
>>
>> Parse the [common] block to create the array of group descriptions:
>>
>> static char *common_cmd_groups[] = {
>> N_("starting a working area"),
>> N_("working on the current change"),
>> N_("working with others"),
>> N_("examining the history and state"),
>> N_("growing, marking and tweaking your history"),
>> };
>>
>> then map each element of common_cmds[] to a group via its index:
>>
>> static struct cmdname_help common_cmds[] = {
>> {"add", N_("Add file contents to the index"), 1},
>> {"branch", N_("List, create, or delete branches"), 4},
>> {"checkout", N_("Checkout a branch or paths to the ..."), 4},
>> {"clone", N_("Clone a repository into a new directory"), 0},
>> {"commit", N_("Record changes to the repository"), 4},
>> ...
>> };
>>
>> so that 'git help' can print those commands grouped by theme.
>>
>> Only commands tagged with an attribute from [common] are emitted to
>> common_cmds[].
>>
>> [commit message by Sébastien Guimmara <sebastien.guimmara@gmail.com>]
>>
>> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
>> Signed-off-by: Sébastien Guimmara <sebastien.guimmara@gmail.com>
>> ---
>
> I seem to be getting an empty common_cmds[] list after this step
> (with GNU Awk 4.0.1, ICIM).
Indeed. I haven't had a chance to look at this version of the series
yet, but a quick glance shows that this is because patch 2/5 uses
"common-" as a prefix rather than as a standalone tag. That is, lines
in patch 2/5 like this:
git-add mainporcelain common-worktree
should be:
git-add mainporcelain common worktree
as proposed here[1]. And, then patch 4/5 should drop the standalone
"common" tag rather than the "common-" prefix.
[1]: http://article.gmane.org/gmane.comp.version-control.git/268756
next prev parent reply other threads:[~2015-05-14 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 12:59 [PATCH 0/5] git help: group common commands by theme Sébastien Guimmara
2015-05-14 12:59 ` [PATCH 1/5] command-list.txt: prepare with [commands] header Sébastien Guimmara
2015-05-14 12:59 ` [PATCH 2/5] command-list.txt: add with [common] block Sébastien Guimmara
2015-05-14 12:59 ` [PATCH 3/5] generate-cmdlist: parse common group commands Sébastien Guimmara
2015-05-14 20:58 ` Junio C Hamano
2015-05-14 21:05 ` Eric Sunshine [this message]
2015-05-15 14:40 ` Sébastien Guimmara
2015-05-14 12:59 ` [PATCH 4/5] command-list.txt: drop the common- prefix Sébastien Guimmara
2015-05-14 12:59 ` [PATCH 5/5] help.c: output the typical Git workflow Sébastien Guimmara
2015-05-14 12:59 ` Sébastien Guimmara
2015-05-14 20:51 ` [PATCH 0/5] git help: group common commands by theme Junio C Hamano
2015-05-15 14:37 ` Sébastien Guimmara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTrDd3eYXo1WPoWRk5XSuLyH_m_VU1JsnP8pjkM=n6O2Q@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sebastien.guimmara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).