git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Benji Kay via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Benji Kay <okaybenji@gmail.com>
Subject: Re: [PATCH] push: improve consistency of output when "up to date"
Date: Thu, 11 Jan 2024 16:45:40 -0500	[thread overview]
Message-ID: <CAPig+cTsDxv4tmULLF-y3eE4q0b=f+W7-ChyYD2MzPxCiLJY8w@mail.gmail.com> (raw)
In-Reply-To: <ZaBhHSCT7EOgTo/N@nand.local>

On Thu, Jan 11, 2024 at 4:44 PM Taylor Blau <me@ttaylorr.com> wrote:
> On Thu, Jan 11, 2024 at 09:27:29PM +0000, Benji Kay via GitGitGadget wrote:
> > -             fprintf(stderr, "Everything up-to-date\n");
> > +             fprintf(stderr, "Everything up to date.\n");
>
> Between the two, I have a vague preference towards "up-to-date", which
> would suggest changing the pull command's output to read "Already
> up-to-date". Personally I think that neither of them should include a
> period in their output, but whichever we decide should be done so
> consistently between the two.
>
> Also, should this string be marked for translation?

See: https://lore.kernel.org/git/7n9r5q74-9qr1-29sr-p2n5-943n01s0p78r@tzk.qr/

  reply	other threads:[~2024-01-11 21:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 21:27 [PATCH] push: improve consistency of output when "up to date" Benji Kay via GitGitGadget
2024-01-11 21:43 ` Eric Sunshine
2024-01-11 22:33   ` Junio C Hamano
     [not found]     ` <CADavbxcFXpP5EQZ=UEMZt+6KKVtCsTMbgQDHEo0uinm0YfRbZA@mail.gmail.com>
2024-01-12  0:55       ` Benji Kay
2024-01-12  3:14     ` Eric Sunshine
2024-01-12 17:19     ` [PATCH] messages: mark some strings with "up-to-date" not to touch Eric Sunshine
2024-01-12 18:19       ` Junio C Hamano
2024-01-15  8:43     ` [PATCH] push: improve consistency of output when "up to date" Patrick Steinhardt
2024-01-11 21:43 ` Taylor Blau
2024-01-11 21:45   ` Eric Sunshine [this message]
2024-01-17 22:02   ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cTsDxv4tmULLF-y3eE4q0b=f+W7-ChyYD2MzPxCiLJY8w@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=okaybenji@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).