From: Askar Safin <safinaskar@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: git@vger.kernel.org
Subject: Re: https://github.com/rust-lang/rust is not bisectable
Date: Sun, 18 Dec 2022 06:15:44 +0300 [thread overview]
Message-ID: <CAPnZJGAMRY02s6UvMg7B6f=NSAgK0PJQAoftwnhXk-ufD2YknQ@mail.gmail.com> (raw)
In-Reply-To: <878rj6rnuo.fsf@igel.home>
At some point that "bootstrap" word appeared, then at some point it
disappeared again. I'm trying to find a point where it has
disappeared. Consider this script:
==begin
#!/bin/bash
set -e
set -x
git bisect reset
git bisect start
git bisect good 7175c499ecc32cb3ff713be0bbac9fd12990a34e
git bisect bad 49c2279ef658d8732597c4da93897d84838f3df5
while :; do
if grep -q bootstrap compiler/rustc_target/src/abi/mod.rs; then
git bisect good
else
git bisect bad
fi
sleep 1
done
==end
Here is the output: https://paste.debian.net/1264444/ . As you can
see, we always choose "else git bisect bad". And we reach... initial
commit!
Well, technically speaking, this is correct: initial commit is
actually the first commit, where word "bootstrap" is not present in
compiler/rustc_target/src/abi/mod.rs . But this is not what I want! I
want to find commit, which is the first one, which doesn't have
"bootstrap" in compiler/rustc_target/src/abi/mod.rs, AND which is
descendant of good commit ( 7175c499ecc32cb3ff713be0bbac9fd12990a34e
).
Also, after failing with "git bisect", I did MANUAL BISECT!!!!!! I did
this: I run command "gitk --ancestry-path $GOOD..$BAD". Then I clicked
to some commit located nearly in the middle of history, then I copied
its ID. Then I switched to this commit and checked whether it is good.
Then I again run command "gitk --ancestry-path $GOOD..$BAD", this time
with a smaller interval. I did this several times and eventually I was
able to find the faulty commit! (Well, the result was not good enough:
this manual bisecting gave me some merge commit, so I still don't see
the actual commit. But it is still better than "git bisect": "git
bisect" simply gave me the initial commit.)
So, as you can see, manual bisecting (somewhat) works and "git bisect"
doesn't. This means that something is wrong with "git bisect". (Maybe
there is a way to make "git bisect" behave similar to that "gitk"
experiment above?)
Let me say this in other words: I want git-bisect to mark all commits,
which are not descendants of good, as good. (Here I assume bad is
descendant of good.)
--
Askar Safin
next prev parent reply other threads:[~2022-12-18 3:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 16:00 https://github.com/rust-lang/rust is not bisectable Askar Safin
2022-12-17 16:34 ` Andreas Schwab
2022-12-18 3:15 ` Askar Safin [this message]
2022-12-18 9:16 ` Andreas Schwab
2022-12-18 9:37 ` SZEDER Gábor
2022-12-18 10:03 ` Askar Safin
2022-12-18 10:25 ` Andreas Schwab
2022-12-18 10:52 ` SZEDER Gábor
2022-12-18 14:10 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnZJGAMRY02s6UvMg7B6f=NSAgK0PJQAoftwnhXk-ufD2YknQ@mail.gmail.com' \
--to=safinaskar@gmail.com \
--cc=git@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).