From: Chris Torek <chris.torek@gmail.com>
To: Ayman Bagabas via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ayman Bagabas" <ayman.bagabas@gmail.com>
Subject: Re: [PATCH v2] shell: allow overriding built-in commands
Date: Sat, 22 Mar 2025 18:11:51 -0700 [thread overview]
Message-ID: <CAPx1Gvd+0XBVm6N6Vrogczhqy8hARajoQ+zDgaaeKMTcSskmeA@mail.gmail.com> (raw)
In-Reply-To: <pull.1930.v2.git.git.1742688740650.gitgitgadget@gmail.com>
I'm not at all sure about any security implications, but aside from that, I
suspect this:
On Sat, Mar 22, 2025 at 5:13 PM Ayman Bagabas via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> + if (!access(full_cmd, F_OK)) {
should use X_OK rather than F_OK.
Chris
next prev parent reply other threads:[~2025-03-23 1:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 10:01 [PATCH] [RFC] shell: allow overriding built-in commands Ayman Bagabas via GitGitGadget
2025-03-22 17:39 ` Elijah Newren
2025-03-22 18:02 ` Ayman Bagabas
2025-03-22 18:26 ` Elijah Newren
2025-03-23 0:12 ` [PATCH v2] " Ayman Bagabas via GitGitGadget
2025-03-23 1:11 ` Chris Torek [this message]
2025-03-23 15:05 ` Ayman Bagabas
2025-03-23 15:12 ` Chris Torek
2025-03-23 15:29 ` [PATCH v3] " Ayman Bagabas via GitGitGadget
2025-03-24 3:25 ` Jeff King
2025-03-24 5:27 ` Junio C Hamano
2025-03-24 20:28 ` Jeff King
2025-03-25 22:44 ` Ayman Bagabas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPx1Gvd+0XBVm6N6Vrogczhqy8hARajoQ+zDgaaeKMTcSskmeA@mail.gmail.com \
--to=chris.torek@gmail.com \
--cc=avarab@gmail.com \
--cc=ayman.bagabas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).