From: John Cai <johncai86@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: "D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org,
"D. Ben Knoble" <ben.knoble+github@gmail.com>
Subject: Re: [PATCH] t4002: fix "diff can read from stdin" syntax
Date: Fri, 14 Jul 2023 14:56:34 -0400 [thread overview]
Message-ID: <CEC94FDD-E5F1-48C0-8FBF-05682EBEB035@gmail.com> (raw)
In-Reply-To: <279beaea-d332-0d88-3cd0-b935ef6bc5eb@web.de>
On 14 Jul 2023, at 10:44, René Scharfe wrote:
> Am 14.07.23 um 15:30 schrieb D. Ben Knoble via GitGitGadget:
>> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
>> index d524d4057dc..7afc883ec37 100755
>> --- a/t/t4002-diff-basic.sh
>> +++ b/t/t4002-diff-basic.sh
>> @@ -403,7 +403,7 @@ test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
>> git diff-tree -r -R $tree_A $tree_B >.test-b &&
>> cmp -s .test-a .test-b'
>>
>> -test_expect_success'diff can read from stdin' '
>> +test_expect_success 'diff can read from stdin' '
>> test_must_fail git diff --no-index -- MN - < NN |
>> grep -v "^index" | sed "s#/-#/NN#" >.test-a &&
>> test_must_fail git diff --no-index -- MN NN |
>>
>
> Good find! Introduced by 9cfcbcc095 (t4002-diff-basic: modernize test
> format, 2023-05-18). Perhaps an automatic formatter would have avoided
> it? E.g. some sed(1) scripting, or shfmt (https://github.com/mvdan/sh)?
> (Just discovered shfmt, never used it.)
Thanks for finding this and fixing!
>
> René
next prev parent reply other threads:[~2023-07-14 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 13:30 [PATCH] t4002: fix "diff can read from stdin" syntax D. Ben Knoble via GitGitGadget
2023-07-14 14:44 ` René Scharfe
2023-07-14 14:53 ` D. Ben Knoble
2023-07-14 18:56 ` John Cai [this message]
2023-07-14 16:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CEC94FDD-E5F1-48C0-8FBF-05682EBEB035@gmail.com \
--to=johncai86@gmail.com \
--cc=ben.knoble+github@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).