From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 02B3CC7619A
	for <git@archiver.kernel.org>; Sun,  2 Apr 2023 18:51:03 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231309AbjDBSvD (ORCPT <rfc822;git@archiver.kernel.org>);
        Sun, 2 Apr 2023 14:51:03 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57028 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231253AbjDBSvC (ORCPT <rfc822;git@vger.kernel.org>);
        Sun, 2 Apr 2023 14:51:02 -0400
Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97D143C12
        for <git@vger.kernel.org>; Sun,  2 Apr 2023 11:50:59 -0700 (PDT)
Received: (Authenticated sender: robin@jarry.cc)
        by mail.gandi.net (Postfix) with ESMTPSA id 4AB5020002;
        Sun,  2 Apr 2023 18:50:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jarry.cc; s=gm1;
        t=1680461458;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=kUMJWpRFf7gwOQiIBK8If5ZXmAGTjryPL6FOv71/OWQ=;
        b=HF8dfZnvRlP1y51Qg/0BfOwGznp9IIfq4baWzD1vODlVF/cP/yjfL8YU5z9OWjh91KQuup
        PUDwb8S/AHUOFL3SKFmn76bEFelF2P4iiObMEs9Stc6qtEd+Z80MZLNxTjYDkCHUJTASyt
        2bFIJyn6wfEc/yXYHxDFNL9AiY08FKcSf2ta53y71Vbtdyu9U9gCk1dHcPOUqyCMjTbUNJ
        saH6ECJhM4MO4JCLcdY66LRPgQv4uGV3MCSxUryUWU44axxBubnnKnNotNQArAIELNxFdf
        RtMtGjsgqEITAphaTfeYxJWJYksKMgnFZaXiY4Z0sK2unkJ26HHcYYlQCViEIw==
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Sun, 02 Apr 2023 20:50:56 +0200
Message-Id: <CRMHVBPXG6SW.2DL6RVNEMVERF@ringo>
Cc:     "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] hooks: add sendemail-validate-series
From:   "Robin Jarry" <robin@jarry.cc>
To:     "Bagas Sanjaya" <bagasdotme@gmail.com>, <git@vger.kernel.org>
X-Mailer: aerc/0.14.0-142-g5dde23f8aa67-dirty
References: <20230103231133.64050-1-robin@jarry.cc>
 <9a0948e2-d030-ac89-a009-9247054f71f9@gmail.com>
In-Reply-To: <9a0948e2-d030-ac89-a009-9247054f71f9@gmail.com>
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Hi,

Bagas Sanjaya, Apr 01, 2023 at 04:54:
> In most cases, the patch series is generated by git-format-patch(1).
> When the command is run, it will output:
>
> ```
> $ git format-patch -o /tmp --cover-letter --base=3D<base-commit> <base-co=
mmit>
> /tmp/0000-cover-letter.patch
> /tmp/0001-<patch-subject>.patch
> /tmp/0002-<patch-subject>.patch
> /tmp/0003-<patch-subject>.patch
> ...
> ```
>
> The output can be fed to the hook (as you write).
>
> But I think the hook should also take patch file arguments, for the
> sake of completeness with sendemail-validate hook; that is:
>
> ```
> sendemail-validate-series <patch file>...
> ```

I don't mind adding this but I am concerned with the maximum size of the
command line arguments when sending large series. Standard input seems
like a safer solution.

> Also, there should have a check that In-Reply-To must be the first
> patch in the given series or the cover letter (if there is one).

This is really non-trivial as it depends on the --[no-]chain-reply-to
and --[no-]thread options. Also, the validation occurs before the
message id headers are generated. I'd prefer trusting git-format-patch
to order the patch files properly based on their file names.

> Anyway, rather than pinging by random people, I'd like to see [PATCH
> RESEND], rebased on latest git.git tree, ideally with Junio Cc'ed.

Will do. Thanks.