From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A2704C76188
	for <git@archiver.kernel.org>; Mon,  3 Apr 2023 22:30:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233813AbjDCWaR (ORCPT <rfc822;git@archiver.kernel.org>);
        Mon, 3 Apr 2023 18:30:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48304 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233737AbjDCWaM (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 3 Apr 2023 18:30:12 -0400
Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6BEA4683
        for <git@vger.kernel.org>; Mon,  3 Apr 2023 15:29:51 -0700 (PDT)
Received: (Authenticated sender: robin@jarry.cc)
        by mail.gandi.net (Postfix) with ESMTPSA id 7D229240004;
        Mon,  3 Apr 2023 22:29:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jarry.cc; s=gm1;
        t=1680560990;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=w16pf3yAWOdXqgsu74/sBbubMFliH5BIskAloD/n6TM=;
        b=WQxsLn9XDnBMHdvCWx/gIVjTdzzt0AwhRePMK6HK3ve9s6+bopQhepI9Q8PzEulqpVA1rI
        MLWfer6RetOtvrOwUP2+s/tQpPs6NrmHbyxvZi/FqI1/8hM1YoXCahb6UYI1HDSxdeGWCm
        Vw0v2e/BdPl+suD/XqfWVFWuxrRAJERtN7q45s/ZonFf/JiqrMkEwfWSywacxk8wRQm4qT
        qOjCitHKzzqVS87Xqr63gcR84YoxQxlj09BBZk5hBqjH4Ln2CdzIPj28JEuHuDEEL10mn2
        43XgjlUUvNsOjgvjW7HNlxoFOqCyypWFDF1aMvHmWlkLFEjkIj+Dw9kN39APoQ==
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 04 Apr 2023 00:29:47 +0200
Message-Id: <CRNH5FOB91JE.14CZEA494X002@ringo>
Cc:     "Tim Culverhouse" <tim@timculverhouse.com>,
        "Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
        "Bagas Sanjaya" <bagasdotme@gmail.com>,
        "Junio C Hamano" <gitster@pobox.com>,
        "Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH RESEND] hooks: add sendemail-validate-series
From:   "Robin Jarry" <robin@jarry.cc>
To:     <phillip.wood@dunelm.org.uk>, <git@vger.kernel.org>
X-Mailer: aerc/0.14.0-145-gedb59e6a06c0
References: <20230402185635.302653-1-robin@jarry.cc>
 <66099367-4ea0-7d2a-a089-7a88e27f695e@dunelm.org.uk>
In-Reply-To: <66099367-4ea0-7d2a-a089-7a88e27f695e@dunelm.org.uk>
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Phillip Wood, Apr 03, 2023 at 16:09:
> Usually git commands that produce or consume paths either use quoted=20
> paths terminated by LF or unquoted paths terminated by NUL. That way=20
> there is no ambiguity when a path contains LF.

Thinking again about that. The probability that a file path name
generated by git-format-patch would contain LF is close to zero.
However, reading per line is more natural and more in line with other
hooks that read from stdin. Having that single hook separating stuff in
stdin with NUL bytes is weird from a user point of view. Don't you think
it would be an acceptable limitation?