From: "Robin Jarry" <robin@jarry.cc>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Phillip Wood" <phillip.wood123@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Tim Culverhouse" <tim@timculverhouse.com>,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Michael Strawbridge" <michael.strawbridge@amd.com>
Subject: Re: [PATCH v2] send-email: export patch counters in validate environment
Date: Wed, 12 Apr 2023 22:39:51 +0200 [thread overview]
Message-ID: <CRV2G5WD329G.3ATH750WRKPIF@ringo> (raw)
In-Reply-To: <xmqq7cug96qv.fsf@gitster.g>
Junio C Hamano, Apr 12, 2023 at 22:37:
> You are the user who just ran format-patch to prepare sending out
> the patches, and you are checking your patches. Wouldn't you have
> the blobs already anyways?
But these will be new blobs since we are applying the patches from files
into another detached branch.
> I'd rather not to see anybody go in that direction. "set -e" is a
> poor substitute for a properly designed error handling. Between
>
> set -e
> command A
> command B
> command C
>
> and
>
> command A &&
> command B &&
> command C || die message
>
> the former can only say "command B" failed because command B was run
> under some condition that it did not like, but that is too low level
> an error that is close to the implementation. As opposed to the
> latter that can talk about what it _means_ that any one of these
> three commands did not succeed in the end-user's terms.
Ok.
next prev parent reply other threads:[~2023-04-12 20:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 11:47 [PATCH] send-email: export patch counters in validate environment Robin Jarry
2023-04-11 13:23 ` Phillip Wood
2023-04-11 16:28 ` Junio C Hamano
2023-04-11 17:13 ` Robin Jarry
2023-04-11 19:14 ` Junio C Hamano
2023-04-11 16:47 ` Robin Jarry
2023-04-12 9:54 ` [PATCH v2] " Robin Jarry
2023-04-12 17:53 ` Junio C Hamano
2023-04-12 18:33 ` Robin Jarry
2023-04-12 20:37 ` Junio C Hamano
2023-04-12 20:39 ` Robin Jarry [this message]
2023-04-12 21:48 ` Junio C Hamano
2023-04-12 21:45 ` [PATCH v3] " Robin Jarry
2023-04-13 13:52 ` Phillip Wood
2023-04-13 14:01 ` Robin Jarry
2023-04-14 12:58 ` Phillip Wood
2023-04-14 15:28 ` [PATCH v4] " Robin Jarry
2023-04-14 15:50 ` Robin Jarry
2023-04-14 15:52 ` [PATCH v5] " Robin Jarry
2023-04-20 19:16 ` Robin Jarry
2023-04-20 19:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRV2G5WD329G.3ATH750WRKPIF@ringo \
--to=robin@jarry.cc \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.strawbridge@amd.com \
--cc=nicolas.dichtel@6wind.com \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tim@timculverhouse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).