From: "Ghanshyam Thakkar" <shyamthakkar001@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] t0024: refactor to have single command per line
Date: Fri, 19 Jan 2024 09:10:04 +0530 [thread overview]
Message-ID: <CYIDCZPQN2H1.1ET0CTP07NMYR@gmail.com> (raw)
In-Reply-To: <xmqqfryunsd1.fsf@gitster.g>
On Fri Jan 19, 2024 at 4:48 AM IST, Junio C Hamano wrote:
> Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:
> > - ( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) &&
> > + mkdir untarred &&
> > + (
> > + cd untarred &&
> > + "$TAR" -xf ../test.tar
> > + ) &&
>
> I think we assume "$TAR" is modern enough to know about the "C"
> option (see t/t5004-archive-corner-cases.sh), so
>
> mkdir untarred &&
> "$TAR" Cxf untarred test.tar
>
> without even a subshell may be sufficient.
I suppose '"$TAR" Cxf untarred test.tar' is not a valid syntax on
alpine, since it was breaking CI.
Instead changed it to '"$TAR" xf test.tar -C untarred' in v3, which
is how it's written in t/t5004-archive-corner-cases.sh, which passes
CI.
next prev parent reply other threads:[~2024-01-19 3:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 21:53 [PATCH 1/2] t0024: avoid losing exit status to pipes Ghanshyam Thakkar
2024-01-18 21:53 ` [PATCH 2/2] t0024: refactor to have single command per line Ghanshyam Thakkar
2024-01-18 23:18 ` Junio C Hamano
2024-01-19 0:57 ` Ghanshyam Thakkar
2024-01-19 3:40 ` Ghanshyam Thakkar [this message]
2024-01-18 23:04 ` [PATCH 1/2] t0024: avoid losing exit status to pipes Junio C Hamano
2024-01-19 1:36 ` [PATCH v2 " Ghanshyam Thakkar
2024-01-19 1:36 ` [PATCH v2 2/2] t0024: style fix Ghanshyam Thakkar
2024-01-19 3:33 ` [PATCH v3 1/2] t0024: avoid losing exit status to pipes Ghanshyam Thakkar
2024-01-19 3:33 ` [PATCH v3 2/2] t0024: style fix Ghanshyam Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYIDCZPQN2H1.1ET0CTP07NMYR@gmail.com \
--to=shyamthakkar001@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).