Git development
 help / color / mirror / Atom feed
From: Kenneth Lorber <keni@his.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/1] config: surface editor failure in exit code
Date: Wed, 19 Aug 2026 14:58:38 -0400	[thread overview]
Message-ID: <D0A00C40-47CC-40A7-BE71-F59C02AF3CCB@his.com> (raw)
In-Reply-To: <xmqqjypmuh3z.fsf@gitster.g>



> On Aug 19, 2026, at 1:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Kenneth Lorber <keni@his.com> writes:
> 
>> (Apologies to anyone who gets this twice.)
> 
> You should not apologize; instead make sure you do not send out the
> same thing twice ;-).
> 
> 
> We actually have 633ac346ee (config: propagate launch_editor()
> failure in show_editor(), 2026-08-12) in flight, so we do not need
> this patch.
> 
> Please build from 'next' and use the resulting "git" binary to try
> it out.
> 
> Thanks.

Works fine, but includes no tests.

Thanks.

  reply	other threads:[~2026-08-19 18:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 21:19 [RFC PATCH 0/1] config: surface editor failure in exit code Kenneth Lorber
2026-08-17 21:19 ` [RFC PATCH 1/1] " Kenneth Lorber
2026-08-18  8:42   ` Karthik Nayak
2026-08-19 11:17     ` Kenneth Lorber
2026-08-19 20:11     ` Junio C Hamano
2026-08-17 22:39 ` [RFC PATCH 0/1] " Junio C Hamano
2026-08-18  8:26   ` Karthik Nayak
2026-08-18 14:31     ` Junio C Hamano
2026-08-18 22:12       ` brian m. carlson
2026-08-19 15:09 ` [PATCH v2 " Kenneth Lorber
2026-08-19 15:09   ` [PATCH v2 1/1] " Kenneth Lorber
2026-08-19 15:09   ` [PATCH v2 0/1] " Kenneth Lorber
2026-08-19 15:09   ` [PATCH v2 1/1] " Kenneth Lorber
2026-08-19 17:58   ` [PATCH v2 0/1] " Junio C Hamano
2026-08-19 18:58     ` Kenneth Lorber [this message]
2026-08-19 19:24       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0A00C40-47CC-40A7-BE71-F59C02AF3CCB@his.com \
    --to=keni@his.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox