git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ghanshyam Thakkar" <shyamthakkar001@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: <git@vger.kernel.org>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] cmake: fix build of `t-oidtree`
Date: Sat, 13 Jul 2024 04:34:46 +0530	[thread overview]
Message-ID: <D2NXQ2WZFF24.1GVN7WUJ5PCHZ@gmail.com> (raw)
In-Reply-To: <xmqqa5iml28j.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > When the `oidtree` test helper was turned into a unit test, a new
> > `lib-oid` source file was added as dependency. This was only done in the
> > Makefile so far, but also needs to be done in the CMake definition.
> >
> > This is a companion of ed548408723d (t/: migrate helper/test-oidtree.c
> > to unit-tests/t-oidtree.c, 2024-06-08).
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     cmake: fix build of t-oidtree
> >     
> >     This is based on the gt/unit-test-oidtree branch.
> >     
> >     /cc "Ghanshyam Thakkar" shyamthakkar001@gmail.com
>
> The base topic has been merged last month during this cycle, so the
> fix must be merged down to the 'master' before the release. Will
> queue.

Changes look correct to me. I was not aware of the existance of
CMakeLists in the tree cause there was no mention of CMake support
in the docs about building git from source, but it was my mistake
for grepping for 'test-lib' in just the Makefile instead of project
wide. Apologies for the negligance and thanks for the patch.


  reply	other threads:[~2024-07-12 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 20:34 [PATCH] cmake: fix build of `t-oidtree` Johannes Schindelin via GitGitGadget
2024-07-12 20:46 ` Johannes Schindelin
2024-07-12 21:38 ` Junio C Hamano
2024-07-12 23:04   ` Ghanshyam Thakkar [this message]
2024-07-13  1:14     ` Junio C Hamano
2024-07-24 10:19     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2NXQ2WZFF24.1GVN7WUJ5PCHZ@gmail.com \
    --to=shyamthakkar001@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).