git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ghanshyam Thakkar" <shyamthakkar001@gmail.com>
To: <phillip.wood@dunelm.org.uk>, <git@vger.kernel.org>
Cc: "Josh Steadmon" <steadmon@google.com>,
	"René Scharfe" <l.s.r@web.de>,
	"Christian Couder" <chriscool@tuxfamily.org>,
	"Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>
Subject: Re: [GSoC][PATCH] t: port helper/test-oid-array.c to unit-tests/t-oid-array.c
Date: Sat, 03 Aug 2024 19:01:45 +0530	[thread overview]
Message-ID: <D36BBC5EWOVX.1CERSXF01H5JI@gmail.com> (raw)
In-Reply-To: <db2f97b6-a06e-470f-b1f9-60a78a0a2a7f@gmail.com>

Hi Phillip,

Phillip Wood <phillip.wood123@gmail.com> wrote:
> On 03/07/2024 04:46, Ghanshyam Thakkar wrote:
> > Note: Once 'rs/unit-tests-test-run' is merged to atleast next, I plan to
> > replace these internal function used in TEST_LOOKUP() with TEST_RUN().
>
> Nice idea

I think the consensus on the 'TEST_RUN()' (which is now 'if_test()')
would take a bit more time and since the v2 removes the use of
internal functions anyways, I think we should not have to wait for
'if_test()' anymore (other things like declaring input varibles inside
the 'if_test()' block can be addressed as an incremental patch once
'if_test()' gets merged). And I've addressed all your other review
points in v2 as well.

Link to v2: https://lore.kernel.org/git/20240803132206.72166-1-shyamthakkar001@gmail.com/

Thanks.


  reply	other threads:[~2024-08-03 13:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03  3:46 [GSoC][PATCH] t: port helper/test-oid-array.c to unit-tests/t-oid-array.c Ghanshyam Thakkar
2024-07-04 16:33 ` Phillip Wood
2024-08-03 13:31   ` Ghanshyam Thakkar [this message]
2024-08-03 13:21 ` [GSoC][PATCH v2] " Ghanshyam Thakkar
2024-08-19 16:55   ` Christian Couder
2024-08-24 17:00     ` Ghanshyam Thakkar
2024-08-24 17:02   ` [GSoC][PATCH v3] " Ghanshyam Thakkar
2024-08-25  6:38     ` Christian Couder
2024-08-25 10:45       ` Ghanshyam Thakkar
2024-09-01 21:26     ` [PATCH v4] " Ghanshyam Thakkar
2024-09-04  7:42       ` Christian Couder
2024-09-04 15:01         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D36BBC5EWOVX.1CERSXF01H5JI@gmail.com \
    --to=shyamthakkar001@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=l.s.r@web.de \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).