From: Caleb White <cdwhite3@pm.me>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Phillip Wood <phillip.wood123@gmail.com>,
shejialuo <shejialuo@gmail.com>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH 1/2] worktree: add CLI/config options for relative path linking
Date: Mon, 28 Oct 2024 01:16:38 +0000 [thread overview]
Message-ID: <D571JAIAQYRE.2KDSYJ5EXL31C@pm.me> (raw)
In-Reply-To: <Zx7YFPE5tjr/bn2s@nand.local>
On Sun Oct 27, 2024 at 7:17 PM CDT, Taylor Blau wrote:
> Looking at the patch below, it is quite large, and I wonder if it would
> benefit from being split into smaller pieces. Perhaps factoring out
> write_worktree_linking_files() in a separate patch would be a good start
> here?
I can try to break it up into smaller patches. I'll start with the one
you suggested and can likely split the tests into their own patch as
well.
Best,
Caleb
next prev parent reply other threads:[~2024-10-28 1:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 22:29 [PATCH 0/2] Allow relative worktree linking to be configured by the user Caleb White
2024-10-25 22:29 ` [PATCH 1/2] worktree: add CLI/config options for relative path linking Caleb White
2024-10-28 0:17 ` Taylor Blau
2024-10-28 0:34 ` Taylor Blau
2024-10-28 16:35 ` Caleb White
2024-10-28 16:54 ` Taylor Blau
2024-10-28 18:50 ` Caleb White
2024-10-28 1:16 ` Caleb White [this message]
2024-10-25 22:29 ` [PATCH 2/2] worktree: add `relativeWorktrees` extension Caleb White
2024-10-28 0:20 ` Taylor Blau
2024-10-28 1:14 ` Caleb White
2024-10-28 17:08 ` Taylor Blau
2024-10-28 19:00 ` Caleb White
2024-10-28 23:36 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D571JAIAQYRE.2KDSYJ5EXL31C@pm.me \
--to=cdwhite3@pm.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=shejialuo@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).