From: "Bence Ferdinandy" <bence@ferdinandy.com>
To: "Rubén Justo" <rjusto@gmail.com>, git@vger.kernel.org
Cc: "Justin Tobler" <jltobler@gmail.com>,
"Heba Waly" <heba.waly@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2] advice: suggest using subcommand "git config set"
Date: Wed, 11 Dec 2024 09:52:27 +0100 [thread overview]
Message-ID: <D68QSB8Y9UTD.1IO0EU3X8ZX39@ferdinandy.com> (raw)
In-Reply-To: <be4ee78e-12d4-44c2-9f82-4f0db7706fea@gmail.com>
On Mon Dec 09, 2024 at 21:35, Rubén Justo <rjusto@gmail.com> wrote:
[snip]
>
> I don't have a strong opinion on this. Since my message, Junio has
> marked this series to be merged to "next". I can be perfectly happy
> with the patch as is.
>
> On the other hand, perhaps I could send my patches about
> `advise_if_enabled()`, later, rebuilt on this series once the dust has
> settled.
I think that would be rather worthwhile, since having different mechanism for
displaying advice isn't the best for sure. And it seems the patch has indeed
made it to "next" recently, so I think it would be safe to rebuild on it now.
Thanks,
Bence
next prev parent reply other threads:[~2024-12-11 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 13:08 [PATCH] advice: suggest using subcommand "git config set" Bence Ferdinandy
2024-12-04 17:19 ` Justin Tobler
2024-12-05 8:21 ` Bence Ferdinandy
2024-12-05 8:30 ` Patrick Steinhardt
2024-12-05 12:21 ` [PATCH v2] " Bence Ferdinandy
2024-12-06 8:57 ` Patrick Steinhardt
2024-12-08 8:08 ` Rubén Justo
2024-12-08 8:12 ` [PATCH 1/3] advice: enhance `detach_advice()` to `detach_advice_if_enabled()` Rubén Justo
2024-12-08 8:12 ` [PATCH 2/3] commit: use `advise_if_enabled()` in `read_graft_file()` Rubén Justo
2024-12-08 8:12 ` [PATCH 3/3] object-name: advice to avoid refs that resemble hashes Rubén Justo
2024-12-09 11:21 ` [PATCH v2] advice: suggest using subcommand "git config set" Bence Ferdinandy
2024-12-09 14:46 ` Bence Ferdinandy
2024-12-09 20:35 ` Rubén Justo
2024-12-11 8:52 ` Bence Ferdinandy [this message]
2024-12-11 18:00 ` Rubén Justo
2024-12-06 2:23 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D68QSB8Y9UTD.1IO0EU3X8ZX39@ferdinandy.com \
--to=bence@ferdinandy.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=heba.waly@gmail.com \
--cc=jltobler@gmail.com \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).