git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bence Ferdinandy" <bence@ferdinandy.com>
To: "Danila Manturov" <danila.manturov@jetbrains.com>, <git@vger.kernel.org>
Subject: Re: Git 2.48. Changed behavior of the git fetch
Date: Sun, 12 Jan 2025 09:07:45 +0100	[thread overview]
Message-ID: <D6ZXVILR1D36.3W0QVQCVE1P2J@ferdinandy.com> (raw)
In-Reply-To: <CAM6buW5KSDGHD7txroqVa0TN_Ou_eV-LocMy06cPy0ZGDQmY9A@mail.gmail.com>


On Thu Jan 09, 2025 at 12:49, Danila Manturov <danila.manturov@jetbrains.com> wrote:
> Hello. I work in TeamCity and we have tests of our git integration
> running with the latest master of the git repository. Some tests
> started to fail since
> https://github.com/git/git/commit/5f212684abb66c9604e745a2296af8c4bb99961c
> I noticed that tags are not fetched with shallow clones. I published
> the test repository to GitHub and reproduced it with commands, the
> result is different for 2.47.1 and 2.48.rc0
>
> git init
> git remote add origin git@github.com:manturovDan/repo_for_shallow_fetch.git
> git fetch --progress --depth=1 --recurse-submodules=no origin
> +fd1eb9776b5fad5cc433586f7933811c6853917d:refs/remotes/origin/main
> git tag | cat
>
> RESULT:
> tag1 (git version 2.47.1)
> <empty> (git version 2.48.0.rc0.38.gff795a5c5e)
>
> the repository log:
> * commit fd1eb9776b5fad5cc433586f7933811c6853917d (tag: tag1, main)
> | Author: Victory Petrenko <vbedrosova@gmail.com>
> | Date:   Wed Feb 3 13:05:03 2021 +0100
> |
> |     recent commit
> |
> * commit 64195c330d99c467a142f682bc23d4de3a68551d
> | Author: Victory Petrenko <vbedrosova@gmail.com>
> | Date:   Wed Feb 3 13:04:44 2021 +0100
> |
> |     change
> |
> * commit a1d6299597f8d6f6d8316577c46cc8fffd657d5e (tag: tag2)
>   Author: Victory Petrenko <vbedrosova@gmail.com>
>   Date:   Wed Feb 3 13:04:17 2021 +0100
>
>       initial commit

This should already be fixed by

6c915c3f85 (fetch: do not ask for HEAD unnecessarily, 2024-12-06)

	[snip]
    Incidentally, because the unconditional request to list "HEAD"
    affected the number of ref-prefixes requested in the ls-remote
    request, this affected how the requests for tags are added to the
    same ls-remote request, breaking "git fetch --tags $URL" performed
    against a URL that is not configured as a remote.

so using 2.48 should be ok.

Best,
Bence


  reply	other threads:[~2025-01-12  8:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 11:49 Git 2.48. Changed behavior of the git fetch Danila Manturov
2025-01-12  8:07 ` Bence Ferdinandy [this message]
     [not found]   ` <CAM6buW6NbdZ6wLGP6LWePiA7n0At=jxxqtBEUv0fTY6mOdTmyw@mail.gmail.com>
     [not found]     ` <D705W1554XJ9.30SRYLNGNOX4@ferdinandy.com>
     [not found]       ` <CAM6buW77CeuKfr3b4SUbYyFaU1OTvRsYBjPBE05YMzJo36bGdw@mail.gmail.com>
     [not found]         ` <D706LPHBPUL4.3LN27T1UG1FI2@ferdinandy.com>
2025-01-13 14:14           ` Danila Manturov
2025-01-13 16:02             ` Bence Ferdinandy
2025-01-21 17:26               ` Danila Manturov
2025-01-26 23:35                 ` Bence Ferdinandy
2025-01-27 11:48                   ` Danila Manturov
2025-01-27 16:36                   ` Bence Ferdinandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6ZXVILR1D36.3W0QVQCVE1P2J@ferdinandy.com \
    --to=bence@ferdinandy.com \
    --cc=danila.manturov@jetbrains.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).