Git development
 help / color / mirror / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>
Cc: <mhagger@alum.mit.edu>, <git@vger.kernel.org>
Subject: Re: [PATCH 00/17] Clean up how fetch_pack() handles the heads list
Date: Fri, 24 Aug 2012 13:46:18 +0100	[thread overview]
Message-ID: <DA390375EB8D4F21ADE618B88F1F0C4C@PhilipOakley> (raw)
In-Reply-To: 7vd32g3ol6.fsf@alter.siamese.dyndns.org

From: "Junio C Hamano" <gitster@pobox.com>
Sent: Friday, August 24, 2012 5:23 AM
> Jeff King <peff@peff.net> writes:
>
>>> It may be (?) that it is a good time to think about a 'datedepth'
>>> capability to bypass the current counted-depth shallow fetch that 
>>> can
>>> cause so much trouble. With a date limited depth the relevant tags
>>> could also be fetched.
>>
>> I don't have anything against such an idea, but I think it is 
>> orthogonal
>> to the issue being discussed here.
>
> Correct.
>
> The biggest problem with the "shallow" hack is that the deepening
> fetch counts from the tip of the refs at the time of deepening when
> deepening the history (i.e. "clone --depth", followed by number of
> "fetch", followed by "fetch --depth").  If you start from a shallow
> clone of depth 1, repeated fetch to keep up while the history grew
> by 100, you would still have a connected history down to the initial
> cauterization point, and "fetch --depth=200" would give you a
> history that is deeper than your original clone by 100 commits.  But
> if you start from the same shallow clone of depth 1, did not do
> anything while the history grew by 100, and then decide to fetch
> again with "fetch --depth=20", it does not grow.  It just makes
> 20-commit deep history from the updated tip, and leave the commit
> from your original clone dangling.
>
> The problem with "depth" does not have anything to do with how it is
> specified at the UI level.

That is, correct me if I'm wrong, the server currently lacks a 
capability to provide anything other than the counted depth shallow 
response (if available). Hence my comment about needing an additional 
server side capability, though that would need a well thought out set of 
use cases to make it useful.

>                                       The end-user input is used to 
> find out
> at what set of commits the history is cauterized, and once they are
> computed, the "shallow" logic solely works on "is the history before
> these cauterization points, or after, in topological terms." (and it
> has to be that way to make sure we get reproducible results).  Even
> if a new way to specify these cauterization points in terms of date
> is introduced, it does not change anything and does not solve the
> fundamental problem the code has when deepening.

fundamental problem = no server capability other than counted depth.
>

      reply	other threads:[~2012-08-24 12:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  8:10 [PATCH 00/17] Clean up how fetch_pack() handles the heads list mhagger
2012-08-23  8:10 ` [PATCH 01/17] t5500: add tests of error output for missing refs mhagger
2012-08-23  8:10 ` [PATCH 02/17] Rename static function fetch_pack() to http_fetch_pack() mhagger
2012-08-23  8:10 ` [PATCH 03/17] Fix formatting mhagger
2012-08-23  8:10 ` [PATCH 04/17] Name local variables more consistently mhagger
2012-08-23  8:39   ` Jeff King
2012-08-24  7:05     ` Michael Haggerty
2012-08-26 17:39     ` Junio C Hamano
2012-08-27  9:22       ` Michael Haggerty
2012-08-27  9:25         ` Jeff King
2012-08-27 16:55           ` Junio C Hamano
2012-08-27 16:50         ` Junio C Hamano
2012-08-23  8:10 ` [PATCH 05/17] Do not check the same match_pos twice mhagger
2012-08-23  8:42   ` Jeff King
2012-08-23  8:10 ` [PATCH 06/17] Let fetch_pack() inform caller about number of unique heads mhagger
2012-08-23  8:54   ` Jeff King
2012-08-25  5:05     ` Michael Haggerty
2012-08-23  8:10 ` [PATCH 07/17] Pass nr_heads to do_pack_ref() by reference mhagger
2012-08-23  8:10 ` [PATCH 08/17] Pass nr_heads to everything_local() " mhagger
2012-08-23  8:10 ` [PATCH 09/17] Pass nr_heads to filter_refs() " mhagger
2012-08-23  8:10 ` [PATCH 10/17] Remove ineffective optimization mhagger
2012-08-23  8:10 ` [PATCH 11/17] filter_refs(): do not leave gaps in return_refs mhagger
2012-08-23  8:10 ` [PATCH 12/17] filter_refs(): compress unmatched refs in heads array mhagger
2012-08-23  8:10 ` [PATCH 13/17] cmd_fetch_pack: return early if finish_connect() returns an error mhagger
2012-08-23  8:10 ` [PATCH 14/17] Report missing refs even if no existing refs were received mhagger
2012-08-23  8:10 ` [PATCH 15/17] cmd_fetch_pack(): simplify computation of return value mhagger
2012-08-23  8:10 ` [PATCH 16/17] fetch_pack(): free matching heads mhagger
2012-08-23  9:04   ` Jeff King
2012-08-23  8:10 ` [PATCH 17/17] fetch_refs(): simplify logic mhagger
2012-08-23  9:07   ` Jeff King
2012-08-25  6:37     ` Michael Haggerty
2012-08-23  9:26 ` [PATCH 00/17] Clean up how fetch_pack() handles the heads list Jeff King
2012-08-23 19:13   ` Philip Oakley
2012-08-23 19:56     ` Jeff King
2012-08-23 20:31       ` Jeff King
2012-08-25  7:05         ` Michael Haggerty
2012-09-02  7:02         ` Michael Haggerty
2012-08-23 22:09       ` Philip Oakley
2012-08-24  4:23       ` Junio C Hamano
2012-08-24 12:46         ` Philip Oakley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA390375EB8D4F21ADE618B88F1F0C4C@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox