Git development
 help / color / mirror / Atom feed
From: Ophir Bleicher <ophirble@gmail.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] setup: fix grammar in code comment
Date: Sat, 21 Nov 2026 19:29:22 +0200	[thread overview]
Message-ID: <DCB2D90D-09E5-4D19-99F9-7E268434952B@gmail.com> (raw)
In-Reply-To: <CALnO6CCJO67E+QA6U4b_p6X9TRwFncc_S6vTs_f6YOX11m0YXA@mail.gmail.com>

OK, I’ll submit another patch...

> On 21 Nov 2026, at 19:27, D. Ben Knoble <ben.knoble@gmail.com> wrote:
> 
> On Sat, Nov 21, 2026 at 11:49 AM Ophir Bleicher via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> 
>> From: Ophir Bleicher <ophirble@gmail.com>
>> 
>> Fix a grammar problem in line 271 of setup.c:
> 
> Is it a grammatical error? I think it's simply the wrong word.
> 
>> will only complain about an inexisting file.
> 
> What a strange little word: it comes from "inexist", which does *not*
> mean "does not exist" but rather "exist within"!
> 
> https://en.wiktionary.org/wiki/inexist#English
> 
>> Change it to 'non-existing'.
> 
> I think "non-existent" (or "missing" or "not found") would be more common here.
> 
>> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
>> ---
>>    setup: fix grammar in code comment
>> 
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v1
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v1
>> Pull-Request: https://github.com/git/git/pull/2500
>> 
>> setup.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/setup.c b/setup.c
>> index cedc031c54..140f1926c4 100644
>> --- a/setup.c
>> +++ b/setup.c
>> @@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
>>  * diagnosis when dying upon finding that "name" is not a pathname.
>>  * If set to 1, the diagnosis will try to diagnose "name" as an
>>  * invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
>> - * will only complain about an inexisting file.
>> + * will only complain about a non-existing file.
>>  *
>>  * This function is typically called to check that a "file or rev"
>>  * argument is unambiguous. In this case, the caller will want
>> 
>> base-commit: f7de81456940dd6f3274e461149bba12965de609
>> --
>> gitgitgadget
>> 
> 
> 
> -- 
> D. Ben Knoble


  reply	other threads:[~2026-11-21 17:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 16:49 [PATCH] setup: fix grammar in code comment Ophir Bleicher via GitGitGadget
2026-11-21 17:27 ` D. Ben Knoble
2026-11-21 17:29   ` Ophir Bleicher [this message]
2026-11-21 17:33 ` [PATCH v2] setup: fix incorrect word " Ophir Bleicher via GitGitGadget
2026-11-21 17:35 ` [PATCH v3] " Ophir Bleicher via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCB2D90D-09E5-4D19-99F9-7E268434952B@gmail.com \
    --to=ophirble@gmail.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox