From: "Burak Kaan Karaçay" <bkkaracay@gmail.com>
To: "Shreyansh Paliwal" <shreyanshpaliwalcmsmn@gmail.com>,
<git@vger.kernel.org>
Subject: Re: [PATCH 2/5] refs: make get_files_ref_lock_timeout_ms() repostory aware
Date: Fri, 27 Mar 2026 12:23:59 +0300 [thread overview]
Message-ID: <DHDGF1CL2QHP.101BB8D2101N8@gmail.com> (raw)
In-Reply-To: <20260325164833.1216577-3-shreyanshpaliwalcmsmn@gmail.com>
On Wed Mar 25, 2026 at 7:44 PM +03, Shreyansh Paliwal wrote:
> -long get_files_ref_lock_timeout_ms(void)
> +long get_files_ref_lock_timeout_ms(struct repository *repo)
> {
> static int configured = 0;
>
> @@ -998,7 +998,7 @@ long get_files_ref_lock_timeout_ms(void)
> static int timeout_ms = 100;
>
> if (!configured) {
> - repo_config_get_int(the_repository, "core.filesreflocktimeout", &timeout_ms);
> + repo_config_get_int(repo, "core.filesreflocktimeout", &timeout_ms);
> configured = 1;
> }
>
Looks like the existing code uses static local variables for
performance. They can behave unexpectedly in multi-repo cases.
I think moving the config into 'repo-settings' should be considered. The
config is already lazy-parsed, migrating it shouldn't be a problem.
Best,
Burak Kaan Karaçay
next prev parent reply other threads:[~2026-03-27 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:44 [PATCH 0/5] refs: reduce reliance on the_repository global state Shreyansh Paliwal
2026-03-25 16:44 ` [PATCH 1/5] refs: make branchname helpers repository aware Shreyansh Paliwal
2026-03-27 7:49 ` Patrick Steinhardt
2026-03-25 16:44 ` [PATCH 2/5] refs: make get_files_ref_lock_timeout_ms() repostory aware Shreyansh Paliwal
2026-03-27 7:50 ` Patrick Steinhardt
2026-03-27 9:23 ` Burak Kaan Karaçay [this message]
2026-03-25 16:44 ` [PATCH 3/5] refs: remove the_hash_algo global state Shreyansh Paliwal
2026-03-25 16:44 ` [PATCH 4/5] refs/reftable-backend: drop uses of the_repository Shreyansh Paliwal
2026-03-27 7:50 ` Patrick Steinhardt
2026-03-25 16:44 ` [PATCH 5/5] refs/packed-backend: use ref_store->repo instead " Shreyansh Paliwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHDGF1CL2QHP.101BB8D2101N8@gmail.com \
--to=bkkaracay@gmail.com \
--cc=git@vger.kernel.org \
--cc=shreyanshpaliwalcmsmn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox