Git development
 help / color / mirror / Atom feed
From: "Matt Hunter" <m@lfurio.us>
To: "Mike Gilbert" <floppym@gentoo.org>, "Patrick Steinhardt" <ps@pks.im>
Cc: <git@vger.kernel.org>, <adrian.ratiu@collabora.com>
Subject: Re: [PATCH] meson: restore hook-list.h to builtin_sources
Date: Fri, 03 Jul 2026 02:03:12 -0400	[thread overview]
Message-ID: <DJOPIP6EQWWJ.H6X9L009RO1W@lfurio.us> (raw)
In-Reply-To: <CAJ0EP43gyQf_XhCLCNEzCq9wMYXZBQX=PWjR-wYqoESSvByJiA@mail.gmail.com>

On Thu Jul 2, 2026 at 1:03 PM EDT, Mike Gilbert wrote:
>
> Thank you for the review. This is my first contribution to the Git
> project and I'm trying to follow the lengthy SubmittingPatches guide.
>
> I believe we have "reached a consensus" and my next steps are as follows:
>
> - Add Reviewed-by (or Acked-by?) for Patrick and Adrian.

I believe the typical etiquette is to only apply someone else's
Reviewed-by trailer if it is offered to you.

> - Send the patch to Junio with the list CCed.

Generally speaking, I'd wait at least a couple days to see if _this_
copy of the patch gets picked up into the 'seen' branch, before
resending for this purpose.

>

I _would_ give my thoughts on the change while I'm here, but I'm not
nearly hip enough to the meson build system to leave anything useful

Welcome to the Git community

      parent reply	other threads:[~2026-07-03  6:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 19:39 [PATCH] meson: restore hook-list.h to builtin_sources Mike Gilbert
2026-07-02 10:34 ` Adrian Ratiu
2026-07-02 11:06 ` Patrick Steinhardt
2026-07-02 17:03   ` Mike Gilbert
2026-07-03  5:21     ` Patrick Steinhardt
2026-07-03  6:03     ` Matt Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJOPIP6EQWWJ.H6X9L009RO1W@lfurio.us \
    --to=m@lfurio.us \
    --cc=adrian.ratiu@collabora.com \
    --cc=floppym@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox