Git development
 help / color / mirror / Atom feed
From: "Pablo Sabater" <pabloosabaterr@gmail.com>
To: "hardikxk" <hardikxk@gmail.com>, <git@vger.kernel.org>
Subject: Re: [PATCH 0/1] Extract only the message log body from git commit.
Date: Wed, 22 Jul 2026 14:38:08 +0200	[thread overview]
Message-ID: <DK53TFGRDS4W.3SYPSLD4HJWIV@gmail.com> (raw)
In-Reply-To: <20260722083836.744338-1-hardikxk@gmail.com>

On Wed Jul 22, 2026 at 10:38 AM CEST, hardikxk wrote:
>
> The patch fixes the `extractLogMessageFromGitCommit` function to skip all the metada of the commit object and only return back the message body.

nit: Let's wrap this at ~72 columns.

>
> Previously the function would return the entire data of the objects
> including authors tree and SHAs. This patch fixes that to skip over all
> that and just return the body of the log message.

This repeats what the commit message already says. For a single-patch
series a cover letter is usually not needed.

Documentation/MyFirstContribution [1] notes that the commit message
should already explain the change at a high level, and that any extra
context can go below the '---' line instead. I would drop this cover
letter unless there's something else to say.

>
> hardikxk (1):
>   Extract only the message body from git commit.
>
>  git-p4.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
>
> base-commit: 48bbf81c29ca9a4479ec7850fe206518682cdb2f

[1]: https://github.com/git/git/blob/master/Documentation/MyFirstContribution.adoc#bonus-chapter-one-patch-changes

Regards,
Pablo


      parent reply	other threads:[~2026-07-22 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  8:38 [PATCH 0/1] Extract only the message log body from git commit hardikxk
2026-07-22  8:38 ` [PATCH 1/1] Extract only the message " hardikxk
2026-07-22 12:23   ` Pablo Sabater
2026-07-22 13:42     ` Hardik Kumar
2026-07-22 12:38 ` Pablo Sabater [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK53TFGRDS4W.3SYPSLD4HJWIV@gmail.com \
    --to=pabloosabaterr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hardikxk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox