Re: [PATCH GSoC 4/5] serve: advertise type capability

["Pablo Sabater" <pabloosabaterr@gmail.com>]

On Wed Jul 29, 2026 at 11:58 AM CEST, Chandra Pratap wrote:
> [snip]
>> -# This tests depends on %(objecttype) not being supported yet, once supported
>> -# it needs to be updated.
>> -test_expect_success 'unsupported placeholder on remote returns empty string' '
>> +test_expect_success 'objecttype is supported by remote-object-info' '
>>         (
>>                 set_transport_variables "$daemon_parent" &&
>>                 cd "$daemon_parent/daemon_client_empty" &&
>>
>> -               echo "" >expect &&
>> +               echo $hello_type >expect &&
>>                 git cat-file --batch-command="%(objecttype)" >actual <<-EOF &&
>>                 remote-object-info "$GIT_DAEMON_URL/parent" $hello_oid
>>                 EOF
>
> Instead of this, what about creating a single test that verifies
> 'type' is supported,
> and modifying this test to verify that the other options are not?
>
> That would actually preserve this test's behaviour and make it easier
> to extend in the future. Something like:
>
> + test_expect_success 'type is supported by remote-object-info'
> + test_expect_success 'unsupported placeholder on remote returns empty string'

Hmmm, it is true that after this test there are no test with the git://
that test for known but unsupported placeholders returning empty
strings, but there are tests from the previous series that does test for
others that are still unsupported like objectmode, deltabase,
objectsize:disk.

I think on more test grouping all the one that remain unsupported will
be good and document.

I'll do exactly what you proposed, thanks,
Pablo