Git development
 help / color / mirror / Atom feed
From: "Brigham Campbell" <me@brighamcampbell.com>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Brigham Campbell" <me@brighamcampbell.com>
Cc: <git@vger.kernel.org>, "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH v2] git-contacts: allow inputting patch via stdin
Date: Thu, 17 Sep 2026 00:56:54 -0600	[thread overview]
Message-ID: <DLHE97Z5RDVA.168ZY5Q3TG8YJ@brighamcampbell.com> (raw)
In-Reply-To: <xmqqa4phxogc.fsf@gitster.g>

On Wed Sep 16, 2026 at 8:25 AM MDT, Junio C Hamano wrote:
> Not necessarily a suggestion to change what you already added, but a
> mere food for thought.
>
> An obvious (and UNIX-y) alternative design would have been to follow
> the popular convention to tell the command to read from the standard
> input stream when "-" is used instead of a filename.  Then this line
> did not have to change, and the command would have allowed arguments
> like:
>
> 	$ git contacts patch1 patch2 - <patch3
> 	$ git contacts patch1 - patch3 <patch2

I considered this approach as well. I may as well have flipped a coin.
My approach to choosing hyphen or no wasn't very scientific.

Naturally, if you'd prefer that I change the approach to instead allow
the user to pass "-" to indicate that a patch should be read via stdin,
I'm happy to send out another revision. I understand why we would rather
get the interface right on the first try, even for something small like
this.

Until you ask me to work a revision that uses "-", I'll await further
review on this v2.

Thanks again for your time!
-- 
Brigham Campbell
https://brighamcampbell.com


  reply	other threads:[~2026-09-17  6:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  2:43 [PATCH] git-contacts: allow inputting patch via stdin Brigham Campbell
2026-09-15  4:29 ` Junio C Hamano
2026-09-16  4:52 ` [PATCH v2] " Brigham Campbell
2026-09-16 14:25   ` Junio C Hamano
2026-09-17  6:56     ` Brigham Campbell [this message]
2026-09-24  1:25 ` [PATCH v3] " Brigham Campbell
2026-09-24  4:13   ` Junio C Hamano
2026-09-25  1:51     ` Brigham Campbell
2026-09-25  4:38       ` Junio C Hamano
2026-09-25  6:42 ` [PATCH v4] " Brigham Campbell
2026-09-25 16:09   ` Junio C Hamano
2026-09-29  5:47 ` [PATCH v5 0/2] " Brigham Campbell
2026-09-29  5:47   ` [PATCH v5 1/2] " Brigham Campbell
2026-09-29 19:29     ` Junio C Hamano
2026-10-02  4:44       ` Brigham Campbell
2026-09-29  5:47   ` [PATCH v5 2/2] git-contacts: add stdin functionality to docs Brigham Campbell
2026-09-29 16:30   ` [PATCH v5 0/2] git-contacts: allow inputting patch via stdin Junio C Hamano
2026-10-02  6:50 ` [PATCH v6] " Brigham Campbell
2026-10-02 14:50   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLHE97Z5RDVA.168ZY5Q3TG8YJ@brighamcampbell.com \
    --to=me@brighamcampbell.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox