From: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] repo: add level of concern reporting
Date: Thu, 29 Oct 2026 16:20:10 -0400 [thread overview]
Message-ID: <DMHLN4FBDV5C.8O60G05LVV3@fastmail.com> (raw)
In-Reply-To: <xmqqld7g1dy4.fsf@gitster.g>
On Thu Oct 29, 2026 at 3:53 PM EDT, Junio C Hamano wrote:
> "Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
>
>> @@ -550,51 +700,76 @@ static void stats_table_setup_structure(struct stats_table *table,
>> stats_table_object_size_addf(table,
>> &objects->largest.commit_size.oid,
>> objects->largest.commit_size.value,
>> + repo_structure_concern_level(
>> + CONCERN_STAT_COMMIT_LARGEST,
>> + objects->largest.commit_size.value,
>> + repo_structure_concern_thresholds),
>> " * %s", _("Maximum size"));
>
> So, objects->largest.commit_size is computed using the value in
> objects->largest.commit_size.value field.
>
>> stats_table_object_size_addf(table,
>> &objects->largest.tree_size.oid,
>> objects->largest.tree_size.value,
>> + repo_structure_concern_level(
>> + CONCERN_STAT_TREE_LARGEST,
>> + objects->largest.commit_size.value,
>> + repo_structure_concern_thresholds),
>> " * %s", _("Maximum size"));
>
> And the same objects->largest.commit_size.value is also used to
> compute objects->largest.tree_size here.
>
> Copy and paste mistake, perhaps?
Argh, yeah. I road through this commit _so_ many times, and still
managed to miss that. Grumble. Will, of course, fix.
-Mark
--
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com
next prev parent reply other threads:[~2026-10-29 20:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 13:55 [PATCH 0/3] repo: add degree-of-concern reporting to structure Mark C. Chu-Carroll
2026-10-21 13:55 ` [PATCH 1/3] repo: add level of concern reporting Mark C. Chu-Carroll
2026-10-21 13:55 ` [PATCH 2/3] repo: make concern thresholds configurable Mark C. Chu-Carroll
2026-10-21 13:55 ` [PATCH 3/3] repo: add documentation for level-of-concern Mark C. Chu-Carroll
2026-10-26 17:43 ` [PATCH v2 0/3] repo: add degree-of-concern reporting to structure Mark C. Chu-Carroll
2026-10-26 17:43 ` [PATCH v2 1/3] repo: add level of concern reporting Mark C. Chu-Carroll
2026-10-27 14:55 ` Patrick Steinhardt
2026-10-26 17:43 ` [PATCH v2 2/3] repo: make concern thresholds configurable Mark C. Chu-Carroll
2026-10-27 14:55 ` Patrick Steinhardt
2026-10-26 17:43 ` [PATCH v2 3/3] repo: add documentation for level-of-concern Mark C. Chu-Carroll
2026-10-27 14:55 ` Patrick Steinhardt
2026-10-28 13:23 ` Mark C. Chu-Carroll
2026-10-27 15:39 ` [PATCH v3 0/2] repo: add degree-of-concern reporting to structure Mark C. Chu-Carroll
2026-10-27 15:39 ` [PATCH v3 1/2] repo: add level of concern reporting Mark C. Chu-Carroll
2026-10-27 15:39 ` [PATCH v3 2/2] repo: make concern thresholds configurable Mark C. Chu-Carroll
2026-10-29 17:52 ` [PATCH v4 0/2] repo: add degree-of-concern reporting to structure Mark C. Chu-Carroll
2026-10-29 17:52 ` [PATCH v4 1/2] repo: add level of concern reporting Mark C. Chu-Carroll
2026-10-29 19:53 ` Junio C Hamano
2026-10-29 20:20 ` Mark C. Chu-Carroll [this message]
2026-10-29 17:52 ` [PATCH v4 2/2] repo: make concern thresholds configurable Mark C. Chu-Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMHLN4FBDV5C.8O60G05LVV3@fastmail.com \
--to=markchucarroll@fastmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox