Git development
 help / color / mirror / Atom feed
From: "Farid Zakaria" <farid.m.zakaria@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Farid Zakaria" <farid.m.zakaria@gmail.com>
Cc: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>,
	<git@vger.kernel.org>, "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH] notes: do not drop notes written by a concurrent process
Date: Thu, 29 Oct 2026 15:16:01 -0700	[thread overview]
Message-ID: <DMHO3TPL4QDJ.2G50G0W2R3ZGB@gmail.com> (raw)
In-Reply-To: <xmqqzevwyyi1.fsf@gitster.g>

On Thu Oct 29, 2026 at 2:42 PM PDT, Junio C Hamano wrote:
> "Farid Zakaria" <farid.m.zakaria@gmail.com> writes:
>
>> I felt confident reviewing the current patch at it's current state
>> (AI-assisted) and I do concur that it's a net-positive change in the
>> interim.
>
> Sorry, but I find the above very confusing, and I cannot figure out
> who is reviewing whose patch, and who is concuring whose statement
> that said what.

It's because I bottom-posted; I thought it might be easier to read that
way -- I guess not.

I was just trying to say that I felt confident in my comprehension of
this current patch, and agreed with Kristoffer that it's a positive
change as it stands, although the algorithm could be improved to handle
cases with different branches as mentioned.

(hopefully that's a little more concise and clear)

      reply	other threads:[~2026-10-29 22:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  3:55 [PATCH] notes: do not drop notes written by a concurrent process Farid Zakaria
2026-10-29 11:05 ` Kristoffer Haugsbakk
2026-10-29 18:25   ` Junio C Hamano
2026-10-29 20:56     ` Farid Zakaria
2026-10-29 21:42       ` Junio C Hamano
2026-10-29 22:16         ` Farid Zakaria [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMHO3TPL4QDJ.2G50G0W2R3ZGB@gmail.com \
    --to=farid.m.zakaria@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox