Git development
 help / color / mirror / Atom feed
From: Yaacov Akiba Slama <ya@slamail.org>
To: unlisted-recipients:; (no To-header on input)
Subject: [PATCH 7/7] Now that the leak is gone, there is by default no limit of revisions to
Date: Wed, 02 Nov 2005 23:51:58 +0200	[thread overview]
Message-ID: <E1EXQWU-00050S-09@localhost.localdomain> (raw)

import.
No more message about leak when the limit (given by the -l parameter)
is reached.

Signed-off-by: Yaacov Akiba Slama <ya@slamail.org>

---

 git-svnimport.perl |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

applies-to: 339bb970b075dfbbd321dcd817591cb739a29584
7410494b72db4c48a27d707a18168076e1b5a3dc
diff --git a/git-svnimport.perl b/git-svnimport.perl
index e97f470..ab690f3 100755
--- a/git-svnimport.perl
+++ b/git-svnimport.perl
@@ -53,7 +53,6 @@ my $branch_name = $opt_b || "branches";
 
 $opt_o ||= "origin";
 $opt_s ||= 1;
-$opt_l = 100 unless defined $opt_l;
 my $git_tree = $opt_C;
 $git_tree ||= ".";
 
@@ -727,15 +726,16 @@ sub commit_all {
 }
 
 while(++$current_rev <= $svn->{'maxrev'}) {
+	if (defined $opt_l) {
+		$opt_l--;
+		if ($opt_l < 0) {
+			last;
+		}
+	}
 	my $pool=SVN::Pool->new;
 	$svn->{'svn'}->get_log("/",$current_rev,$current_rev,1,1,1,\&_commit_all,$pool);
 	$pool->clear;
 	commit_all();
-	if($opt_l and not --$opt_l) {
-		print STDERR "Stopping, because there is a memory leak (in the SVN library).\n";
-		print STDERR "Please repeat this command; it will continue safely\n";
-		last;
-	}
 }
 
 
---
0.99.9.GIT

                 reply	other threads:[~2005-11-02 21:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1EXQWU-00050S-09@localhost.localdomain \
    --to=ya@slamail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox