From: Matthias Lederhofer <matled@gmx.net>
To: git@vger.kernel.org
Subject: [PATCH 1/5] daemon: use a custom die routine with syslog
Date: Thu, 13 Jul 2006 12:02:29 +0200 [thread overview]
Message-ID: <E1G0znB-0002IH-5K@moooo.ath.cx> (raw)
In-Reply-To: <E1G0zj7-0001c1-8q@moooo.ath.cx>
Removed the git-daemon prefix from die() because no other call to die
does this.
Signed-off-by: Matthias Lederhofer <matled@gmx.net>
---
daemon.c | 19 +++++++++++--------
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/daemon.c b/daemon.c
index e096bd7..a7636bc 100644
--- a/daemon.c
+++ b/daemon.c
@@ -95,6 +95,12 @@ static void loginfo(const char *err, ...
va_end(params);
}
+static void NORETURN daemon_die(const char *err, va_list params)
+{
+ logreport(LOG_ERR, err, params);
+ exit(1);
+}
+
static int avoid_alias(char *p)
{
int sl, ndot;
@@ -746,17 +752,14 @@ int main(int argc, char **argv)
usage(daemon_usage);
}
- if (log_syslog)
+ if (log_syslog) {
openlog("git-daemon", 0, LOG_DAEMON);
-
- if (strict_paths && (!ok_paths || !*ok_paths)) {
- if (!inetd_mode)
- die("git-daemon: option --strict-paths requires a whitelist");
-
- logerror("option --strict-paths requires a whitelist");
- exit (1);
+ set_die_routine(daemon_die);
}
+ if (strict_paths && (!ok_paths || !*ok_paths))
+ die("option --strict-paths requires a whitelist");
+
if (inetd_mode) {
struct sockaddr_storage ss;
struct sockaddr *peer = (struct sockaddr *)&ss;
--
1.4.1.gb16f
next prev parent reply other threads:[~2006-07-13 11:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 22:24 git-daemon problem Matthias Lederhofer
2006-07-11 23:04 ` Junio C Hamano
2006-07-11 23:32 ` Junio C Hamano
2006-07-12 4:42 ` Junio C Hamano
2006-07-12 19:28 ` Matthias Lederhofer
2006-07-13 5:44 ` Junio C Hamano
2006-07-13 7:42 ` Matthias Lederhofer
2006-07-13 11:42 ` Andre Noll
2006-07-13 11:51 ` Matthias Lederhofer
2006-07-13 10:02 ` Matthias Lederhofer [this message]
2006-07-13 10:10 ` [PATCH 2/5] daemon: if one of the standard fds is missing open it to /dev/null Matthias Lederhofer
2006-07-13 13:27 ` Edgar Toernig
2006-07-13 14:04 ` Matthias Lederhofer
2006-07-13 14:36 ` Uwe Zeisberger
2006-07-13 15:37 ` Morten Welinder
2006-07-13 16:03 ` Matthias Lederhofer
2006-07-13 16:32 ` [PATCH 2.1/5] " Matthias Lederhofer
2006-07-13 10:18 ` [PATCH 4/5] daemon: new option --pid-file=<path> to store the pid Matthias Lederhofer
2006-07-13 10:32 ` [PATCH 5/5] daemon: new option --detach to run git-daemon in background Matthias Lederhofer
2006-07-13 13:37 ` Edgar Toernig
2006-07-13 16:47 ` [PATCH 5.1/5] " Matthias Lederhofer
2006-07-13 11:07 ` [PATCH 3/5] upload-pack: ignore write errors to stderr Matthias Lederhofer
2006-07-14 15:53 ` [PATCH] daemon: documentation for --reuseaddr, --detach and --pid-file Matthias Lederhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1G0znB-0002IH-5K@moooo.ath.cx \
--to=matled@gmx.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).