Re: [PATCH] gitweb.cgi: Customization

[Matthias Lederhofer <matled@gmx.net>]

Junio C Hamano <junkio@cox.net> wrote:
> They all try to make customization can be done in one
> place, and the difference is mostly of taste, so I'd just pick
> one from Martin.
I hope it will be possible (see require suggestion from Jeff King) to
specify the file also from the environment because then it is possible
to develop on an uncostumized version of gitweb.perl.  Now I noticed
a problem: do not use the @@FOO@@ in double quotes because perl will
spit a lot of warnings like
"Possible unintended interpolation of @GIT_VERSION in string"
Either we should use another delimiter or use single quotes (this is
the way it is done in git-send-email.perl and git-svn.perl).  I don't
know how likely it is that characters that are interpreted different
in double quotes are in filenames but I'd prefer single quotes just to
be on the safe site.  This disallows using '/etc/foo/$ENV{SITE_NAME}'
as config file but one can just use '/etc/foo/bar' which requires
'/etc/foo/$ENV{SITE_NAME}'.