From: Michael Adam <obnox@samba.org>
To: git@vger.kernel.org
Cc: Andy Parkins <andyparkins@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Michael Adam <obnox@samba.org>
Subject: [PATCH v2] contrib/hooks/post-receive-email: send individual mails to recipients
Date: Wed, 12 Nov 2008 17:50:15 +0100 [thread overview]
Message-ID: <E1L0Iv1-00BwsF-Jh@intern.SerNet.DE> (raw)
This changes the behaviour of post-receive-email when a list of recipients
(separated by commas) is specified as hooks.mailinglist. With this modification,
an individual mail is sent out for each recipient entry in the list, instead
of sending a single mail with all the recipients in the "To: " field.
Signed-off-by: Michael Adam <obnox@samba.org>
---
Sorry, in the first version of the patch, I forgot to
adapt the generate_email_header() function fill the "To"
field only with "$recipient" instad of "$recipients".
Cheers - Michael
contrib/hooks/post-receive-email | 32 ++++++++++++++++++--------------
1 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 28a3c0e..f8bbeab 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -169,21 +169,25 @@ generate_email()
describe=$rev
fi
- generate_email_header
+ # loop over the recipients to send individual mails
+ echo $recipients | sed -e 's/\s*,\s*/\n/' | while read recipient
+ do
+ generate_email_header
- # Call the correct body generation function
- fn_name=general
- case "$refname_type" in
- "tracking branch"|branch)
- fn_name=branch
- ;;
- "annotated tag")
- fn_name=atag
- ;;
- esac
- generate_${change_type}_${fn_name}_email
+ # Call the correct body generation function
+ fn_name=general
+ case "$refname_type" in
+ "tracking branch"|branch)
+ fn_name=branch
+ ;;
+ "annotated tag")
+ fn_name=atag
+ ;;
+ esac
+ generate_${change_type}_${fn_name}_email
- generate_email_footer
+ generate_email_footer
+ done
}
generate_email_header()
@@ -191,7 +195,7 @@ generate_email_header()
# --- Email (all stdout will be the email)
# Generate header
cat <<-EOF
- To: $recipients
+ To: $recipient
Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
X-Git-Refname: $refname
X-Git-Reftype: $refname_type
--
1.5.6
next reply other threads:[~2008-11-12 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 16:50 Michael Adam [this message]
2008-11-12 17:08 ` [PATCH v2] contrib/hooks/post-receive-email: send individual mails to recipients Johannes Sixt
2008-11-12 17:42 ` Michael Adam
2008-11-12 18:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1L0Iv1-00BwsF-Jh@intern.SerNet.DE \
--to=obnox@samba.org \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).