Git development
 help / color / mirror / Atom feed
From: Michael Adam <obnox@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Andy Parkins <andyparkins@gmail.com>
Subject: Re: [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients
Date: Wed, 12 Nov 2008 23:21:23 +0100	[thread overview]
Message-ID: <E1L0O5U-00CBIw-3Y@intern.SerNet.DE> (raw)
In-Reply-To: <7v3ahwq043.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> Michael Adam <obnox@samba.org> writes:
> 
> > Junio C Hamano wrote:
> >> Michael Adam <obnox@samba.org> writes:
> >> 
> >> > This changes the behaviour of post-receive-email when a list of recipients
> >> > (separated by commas) is specified as hooks.mailinglist. With this modification,
> >> > an individual mail is sent out for each recipient entry in the list, instead
> >> > of sending a single mail with all the recipients in the "To: " field.
> >> 
> >> Why can that be an improvement?
> >
> > My use case is that I have a repository where I want to send
> > commit messages to an "official" mailing list and to a private
> > recipient list that might not want to be seen on the official
> > mailing list.
> 
> Ah.  What you want is a capability to add Bcc:, not a misfeature to run
> the log formatter repeatedly wasting cycles only to generate the same
> message contents.

The intent was to send out the mail not to a (large) list of
individual recipients but to some (few) mailing lists separately.
A Bcc would be a partial solution. I also thought about that, but
I did not like it since it might make those recipients in the bcc
field feel strange because they seem to be getting mail from a
list they might not be subscribed to. Group-replying to such
mails may also cause confusion...

Of course my patch could be optimized for not wasting cycles by
only running generate_email_header() multiple times and caching
the results of the log formatter and generate_email_footer().

But I understand that my problem is a very specific one and that
generally no benefit but only disadvantage is seen in the
modification I suggested.  --  Sorry for the noise. :-)

Cheers - Michael

      reply	other threads:[~2008-11-12 22:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12 16:21 [PATCH] contrib/hooks/post-receive-email: send individual mails to recipients Michael Adam
2008-11-12 17:49 ` Junio C Hamano
2008-11-12 17:58   ` Michael Adam
2008-11-12 18:18     ` Junio C Hamano
2008-11-12 22:21       ` Michael Adam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1L0O5U-00CBIw-3Y@intern.SerNet.DE \
    --to=obnox@samba.org \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox