git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.keller@gmail.com>
To: Philip Oakley <philipoakley@iee.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/5] doc: add documentation for OPT_STRING_LIST
Date: Sun, 18 Dec 2016 04:19:38 -0800	[thread overview]
Message-ID: <E9C90A8A-8D05-4357-BCEF-AAFAE16225CC@gmail.com> (raw)
In-Reply-To: <67572777448E4DCE967BA079110A3487@PhilipOakley>

On December 17, 2016 3:56:19 AM PST, Philip Oakley <philipoakley@iee.org> wrote:
>From: "Jacob Keller" <jacob.e.keller@intel.com>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> Commit c8ba16391655 ("parse-options: add OPT_STRING_LIST helper",
>> 2011-06-09) added the OPT_STRING_LIST as a way to accumulate a
>repeated
>> list of strings. However, this was not documented in the
>> api-parse-options documentation. Add documentation now so that future
>> developers may learn of its existence.
>>
>> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
>> ---
>> Documentation/technical/api-parse-options.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/technical/api-parse-options.txt 
>> b/Documentation/technical/api-parse-options.txt
>> index 27bd701c0d68..92791740aa64 100644
>> --- a/Documentation/technical/api-parse-options.txt
>> +++ b/Documentation/technical/api-parse-options.txt
>> @@ -168,6 +168,11 @@ There are some macros to easily define options:
>>  Introduce an option with string argument.
>>  The string argument is put into `str_var`.
>>
>> +`OPT_STRING_LIST(short long, &list, arg_str, description)`::
>
>should there be an extra comma between 'short long' in a similar manner
>to 
>the OPT_INTEGER argument list below?
>
>

You are indeed correct sir. I will fix this up.

Thanks,
Jake


  reply	other threads:[~2016-12-18 12:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17  1:24 [PATCH v2 0/5] extend describe and name-rev pattern matching Jacob Keller
2016-12-17  1:24 ` [PATCH v2 1/5] doc: add documentation for OPT_STRING_LIST Jacob Keller
2016-12-17 11:56   ` Philip Oakley
2016-12-18 12:19     ` Jacob Keller [this message]
2016-12-17  1:24 ` [PATCH v2 2/5] name-rev: extend --refs to accept multiple patterns Jacob Keller
2016-12-17  1:24 ` [PATCH v2 3/5] name-rev: add support to discard refs by pattern match Jacob Keller
2016-12-17  1:24 ` [PATCH v2 4/5] describe: teach --match to accept multiple patterns Jacob Keller
2016-12-17  1:24 ` [PATCH v2 5/5] describe: teach describe negative pattern matches Jacob Keller
  -- strict thread matches above, loose matches on Subject: below --
2017-01-18  0:03 [PATCH v2 0/5] extend git-describe pattern matching Jacob Keller
2017-01-18  0:03 ` [PATCH v2 1/5] doc: add documentation for OPT_STRING_LIST Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E9C90A8A-8D05-4357-BCEF-AAFAE16225CC@gmail.com \
    --to=jacob.keller@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jacob.e.keller@intel.com \
    --cc=philipoakley@iee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).