Git development
 help / color / mirror / Atom feed
From: "Jason Pyeron" <jpyeron@pdinc.us>
To: "'git'" <git@vger.kernel.org>
Subject: RE: Millisecond precision in timestamps?
Date: Tue, 27 Nov 2012 20:29:45 -0500	[thread overview]
Message-ID: <EE15DF282E7C4196A32EE0818A64E35D@black> (raw)
In-Reply-To: <20121128011750.GA23498@sigill.intra.peff.net>

> -----Original Message-----
> From: Jeff King
> Sent: Tuesday, November 27, 2012 20:18
> 
> On Tue, Nov 27, 2012 at 05:07:34PM -0800, Shawn O. Pearce wrote:
> 
> > On Tue, Nov 27, 2012 at 4:26 PM, Felipe Contreras 
> > <felipe.contreras@gmail.com> wrote:
> > > On Wed, Nov 28, 2012 at 1:12 AM, Eric S. Raymond 
> <esr@thyrsus.com> wrote:
> > >> Shawn Pearce <spearce@spearce.org>:
> > >>> Well... if we added a fractional seconds to a commit, older 
> > >>> versions of Git will scream loudly and refuse to work 
> with the new 
> > >>> commit. That would create a fork of Git.
> > >>
> > >> So much for that idea, I guess.
> > >>
> > >> Unless..I don't know how git's database representations 
> work.  Are 
> > >> they version-stamped in any way?  If so, some slightly painful 
> > >> hackery would get around that problem.
> > >
> > > % git cat-file -p HEAD
> > >
> > > You'll see exactly how git stores commits. Changing anything in 
> > > there must be done carefully.
> > 
> > Apparently there is no room to change in these fields 
> without breaking 
> > compatibility with all current versions of Git. So its not 
> just done 
> > carefully... its deciding to make Git 2.0 that is not 
> compatible with 
> > any Git 1.x release.
> 
> There is room for new headers, and older versions of git will 
> ignore them. You could add a new "committer-timestamp" field 
> that elaborates on the timestamp included on the committer 
> line. Newer versions of git would respect it, and older 
> versions would fall back to using the committer timestamp.

Suggestion add a ms offset field. Ex:

jpyeron@black /projects/git/git
$ git cat-file -p HEAD
tree 1e24acfbfcc05aa57e8cb2cfe3ffe01cb100961d
parent e98fa647aa5673cc95b6e9be1fdc13c0afa2cb37
author Junio C Hamano <gitster@pobox.com> 1350495361 -0700
committer Junio C Hamano <gitster@pobox.com> 1350495402 -0700
mstimestamps author 0 committer 1234

Git 1.7.12.4

Signed-off-by: Junio C Hamano <gitster@pobox.com>


> 
> But I really wonder if anybody actually cares about adding 
> sub-second timestamp support, or if it is merely "because SVN has it".

Not because subversion has it but because date != git(precisedate) and some
automation using git in a larger enterprise workflow may assume that date
1354065991.1234 going in should be the same when queried.

-Jason



--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-                                                               -
- Jason Pyeron                      PD Inc. http://www.pdinc.us -
- Principal Consultant              10 West 24th Street #100    -
- +1 (443) 269-1555 x333            Baltimore, Maryland 21218   -
-                                                               -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.

  reply	other threads:[~2012-11-28  1:30 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 20:48 Millisecond precision in timestamps? Eric S. Raymond
2012-11-27 21:41 ` Shawn Pearce
2012-11-27 22:06   ` Junio C Hamano
2012-11-27 23:04     ` Eric S. Raymond
2012-11-27 23:49       ` Shawn Pearce
2012-11-28  0:12         ` Eric S. Raymond
2012-11-28  0:22           ` David Lang
2012-11-28  0:26           ` Felipe Contreras
2012-11-28  1:07             ` Shawn Pearce
2012-11-28  1:17               ` Jeff King
2012-11-28  1:29                 ` Jason Pyeron [this message]
2012-11-28  1:42                 ` Felipe Contreras
2012-11-28  3:23                 ` Eric S. Raymond
2012-11-28  3:30                   ` Jeff King
2012-11-28  3:44                     ` Felipe Contreras
2012-11-28  3:47                     ` Eric S. Raymond
2012-11-28  4:07                       ` Jeff King
2012-11-28  4:25                         ` Eric S. Raymond
2012-11-28  7:29                 ` Junio C Hamano
2012-11-28  7:58                   ` Eric S. Raymond
2012-11-28  8:04                     ` David Aguilar
2012-11-28 10:14                       ` Andreas Ericsson
2012-12-05 23:37                       ` Robin Rosenberg
2012-12-10 20:56                     ` James Cloos
2012-11-28  8:19                   ` Thomas Berg
2012-11-28  8:44                     ` Felipe Contreras
2012-11-28  9:10                       ` Thomas Berg
     [not found]                         ` <E4C993F4-B7A4-4CB6-A9EA-BFE98BE3A381@gmail.com>
2012-11-29  6:16                           ` Eric S. Raymond
2012-11-29  7:11                           ` Junio C Hamano
2012-11-29  7:22                             ` Felipe Contreras
2012-11-29 10:38                               ` Eric S. Raymond
2012-11-29 16:42                                 ` Junio C Hamano
2012-11-29 19:02                                   ` Eric S. Raymond
2012-11-28 17:57                     ` Junio C Hamano
2012-11-28 10:10                   ` Andreas Ericsson
2012-11-29 19:14                   ` Phil Hord
2012-11-29 20:01                     ` Jeff King
2012-11-28  1:11             ` Eric S. Raymond
2012-11-28  1:36               ` Felipe Contreras
2012-11-28  2:01       ` Junio C Hamano
2012-11-27 21:44 ` Pyeron, Jason J CTR (US)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EE15DF282E7C4196A32EE0818A64E35D@black \
    --to=jpyeron@pdinc.us \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox