From: Brian Gernhardt <benji@silverinsanity.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Use "-f" when adding files with odd names in t9200.
Date: Sun, 4 Feb 2007 20:55:02 -0500 [thread overview]
Message-ID: <EF3945DB-1CCB-4D8A-8300-FD4EB31CD583@silverinsanity.com> (raw)
In-Reply-To: <7vwt2xpezx.fsf@assigned-by-dhcp.cox.net>
On Feb 4, 2007, at 8:30 PM, Junio C Hamano wrote:
> In reality, I find highly valuable that our tests find new bugs
> introduced in unexpected places. I agree that the person who
> wrote t9200 did not _mean_ to test "git add", but it ended up
> helping us identify the problematic behaviour between creat()
> and readdir() on HFS+ affects "git add".
Alright, I understand that. I just meant that since we've identified
it, the workaround didn't matter much.
> So how about doing this instead? It tests if the filesystem has
> that particular issue we know "git add" has a problem with, and
> skips the test in such an environment.
Yes, something like this is fine. The patch looks good, but I
couldn't get it to apply and don't have the time to fix it at the
moment. If you *need* me to test it, I'll do so tomorrow or Tuesday.
~~ Brian
next prev parent reply other threads:[~2007-02-05 1:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-03 15:56 t9200 still failing Brian Gernhardt
2007-02-03 16:17 ` Wolfgang Fischer
2007-02-03 17:41 ` Brian Gernhardt
2007-02-03 18:13 ` [PATCH] Use "-f" when adding files with odd names in t9200 Brian Gernhardt
2007-02-03 19:42 ` Junio C Hamano
2007-02-03 20:12 ` Brian Gernhardt
2007-02-03 20:51 ` Junio C Hamano
2007-02-03 21:31 ` Brian Gernhardt
2007-02-03 23:50 ` Junio C Hamano
2007-02-04 1:09 ` Junio C Hamano
2007-02-04 3:47 ` Shawn O. Pearce
2007-02-04 16:35 ` Brian Gernhardt
2007-02-04 16:50 ` Brian Gernhardt
2007-02-05 1:30 ` Junio C Hamano
2007-02-05 1:55 ` Brian Gernhardt [this message]
2007-02-06 15:17 ` Brian Gernhardt
[not found] ` <82643737-7D5F-4A73-83BA-EB5AD9BBA5EA@wf227.com>
2007-02-03 19:41 ` t9200 still failing Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF3945DB-1CCB-4D8A-8300-FD4EB31CD583@silverinsanity.com \
--to=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).