From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Users <git@vger.kernel.org>
Subject: Re: [RFC] URL rewrite in .gitmodules
Date: Sun, 25 Oct 2015 16:12:23 +0100 [thread overview]
Message-ID: <F01EF930-9787-44DD-A2E5-F5FBA029D3E7@gmail.com> (raw)
In-Reply-To: <xmqqio618mxc.fsf@gitster.mtv.corp.google.com>
On 20 Oct 2015, at 19:33, Junio C Hamano <gitster@pobox.com> wrote:
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>> If not, what do you think about a patch that adds a "url" section
>> similar to the one in git config to a .gitmodules file?
>>
>> Example:
>> ----------
>> [submodule "git"]
>> path = git
>> url=git://github.com/larsxschneider/git.git
>>
>> [url "mycompany.com"]
>> insteadOf = outside.com
>> ----------
>
> It is unclear to me if you are adding the last two (or three,
> counting the blank before) lines to your company's private fork of
> the opensource project, but if that is the case, then that would
> defeat your earlier desire:
>
>> ... I also would prefer not to do this as I want to use the
>> very same hashes as defined by the "upstream" ...
>
> wouldn't it?
The last three lines are added to my companies closed source Git repo. In this example the company repo references git://github.com/larsxschneider/git.git as submodule. This submodule in turn references another submodule with a URL "outside.com". This is the URL I want to rewrite. Do you think this could be useful to others as well?
> I do not think this topic is specific to use of submodules. If you
> want to encourage your engineers to fetch from nearby mirrors you
> maintain, you would want a forest of url.mine.insteadof=theirs for
> the external repositories that matter to you specified by
> everybody's $HOME/.gitconfig, and one way to do so would be to have
> them use the configuration inclusion. An item in your engineer
> orientation material could tell them to add
>
> [include]
> path = /usr/local/etc/git/mycompany.urlrewrite
>
> when they set up their "[user] name/email" in there.
>
> And you can update /usr/local/etc/git/mycompany.urlrewrite as
> needed.
Oh nice, I didn't know about "include". However, as mentioned to Stefan in this thread, I fear that our engineers will miss that. I would prefer a solution that does not need any additional setup. Therefore the suggestion to add rewrites in the .gitmodules file.
Thanks,
Lars
next prev parent reply other threads:[~2015-10-25 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 19:28 [RFC] URL rewrite in .gitmodules Lars Schneider
2015-10-19 22:07 ` Stefan Beller
2015-10-25 14:43 ` Lars Schneider
2015-10-20 17:33 ` Junio C Hamano
2015-10-25 15:12 ` Lars Schneider [this message]
2015-10-26 16:34 ` Stefan Beller
2015-10-26 16:52 ` Jens Lehmann
2015-11-15 13:16 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F01EF930-9787-44DD-A2E5-F5FBA029D3E7@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).