From: Ben Knoble <ben.knoble@gmail.com>
To: Jun Wu <quark.zju@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, peff@peff.net, ps@pks.im,
Jun Wu <quark@meta.com>
Subject: Re: [PATCH 1/2] repository: add core.indexLockTimeout
Date: Mon, 19 Oct 2026 12:23:40 -0400 [thread overview]
Message-ID: <F02EB9EC-E157-49D2-BF27-81DFF625D884@gmail.com> (raw)
In-Reply-To: <20261014221233.1694344-1-quark.zju@gmail.com>
> Le 14 oct. 2026 à 18:13, Jun Wu <quark.zju@gmail.com> a écrit :
>
> On Tue, 13 Oct 2026 15:05:52 -0700, Junio C Hamano wrote:
>>> Default timeout is 1s, effective but not too long to avoid breaking potential
>>> user expectation (e.g. "an index.lock error means I should check whether a
>>> commit message editor is open somewhere"). Tests that are slowed down by the
>>> default timeout now set the timeout to 0.
>
>> I am not sure if the change is making the right trade-off between
>> background tasks and end-user action that expects immediate
>> response.
>
> It seems the trade-off is between command success rate and command duration.
>
> I suspect that end-users want commands to work (not fail) first, performance
> comes next. In my experience, high command failure rate escalates to oncall
> incidents, occasional slightly slower commands often get unnoticed unless we
> look at the metrics explicitly.
I’ve given it some more thought, and acknowledging that
I’m unaffected by the bug being fixed, I would add:
It seems like working flows have to become more complex
to handle these broken flows. And that leaves a sour taste for me.
Folks do notice hangups at a shell that is typically quick to respond.
But, as I said, I’ll bow out since it seems like there’s some support
from more experienced folks for this direction.
next prev parent reply other threads:[~2026-10-19 16:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 17:23 [PATCH 0/2] Add a way to wait for index lock Jun Wu
2026-10-13 17:23 ` [PATCH 1/2] repository: add core.indexLockTimeout Jun Wu
2026-10-13 21:40 ` D. Ben Knoble
2026-10-14 2:38 ` Jun Wu
2026-10-14 16:29 ` D. Ben Knoble
2026-10-13 22:05 ` Junio C Hamano
2026-10-14 22:12 ` Jun Wu
2026-10-19 16:23 ` Ben Knoble [this message]
2026-10-13 17:23 ` [PATCH 2/2] commit: lock index before reading Jun Wu
2026-10-14 10:04 ` Jeff King
2026-10-15 0:19 ` Jun Wu
2026-10-13 22:05 ` [PATCH 0/2] Add a way to wait for index lock Junio C Hamano
2026-10-14 22:12 ` Jun Wu
2026-10-14 10:14 ` Jeff King
2026-10-17 7:32 ` [PATCH v2 0/4] Wait for the index lock instead of failing Jun Wu
2026-10-17 7:32 ` [PATCH v2 1/4] repository: add repo_try_hold_locked_index() Jun Wu
2026-10-17 7:32 ` [PATCH v2 2/4] repository: add core.indexLockTimeout Jun Wu
2026-10-17 7:32 ` [PATCH v2 3/4] commit: fix write race Jun Wu
2026-10-17 7:32 ` [PATCH v2 4/4] reset: " Jun Wu
2026-10-22 18:49 ` [PATCH v2 0/4] Wait for the index lock instead of failing Mihai Cosma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F02EB9EC-E157-49D2-BF27-81DFF625D884@gmail.com \
--to=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=quark.zju@gmail.com \
--cc=quark@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox