Git development
 help / color / mirror / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: "Jeff King" <peff@peff.net>
Cc: "GitList" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH] Doc User-Manual: Patch cover letter, three dashes, and --notes
Date: Thu, 25 Oct 2012 23:45:57 +0100	[thread overview]
Message-ID: <F4D36C50EB6945CD8EB6E5AF73238148@PhilipOakley> (raw)
In-Reply-To: 20121025102638.GP8390@sigill.intra.peff.net

From: "Jeff King" <peff@peff.net> Sent: Thursday, October 25, 2012 11:26 
AM
> On Sun, Oct 21, 2012 at 10:34:08PM +0100, Philip Oakley wrote:
>
>> diff --git a/Documentation/user-manual.txt 
>> b/Documentation/user-manual.txt
>> index 85651b5..d918c53 100644
>> --- a/Documentation/user-manual.txt
>> +++ b/Documentation/user-manual.txt
>> @@ -1787,6 +1787,11 @@ $ git format-patch origin
>>  will produce a numbered series of files in the current directory, 
>> one
>>  for each patch in the current branch but not in origin/HEAD.
>>
>> +`git format-patch` can include an initial "cover letter". You can 
>> insert
>> +a commentary on individual patches using a three dash line after the
>> +commit message, and before the patch itself. `git 
>> format-patch --notes`
>> +(v1.8.1) will include the commit's notes in the similar manner.
>
> I'd rather not mention a version number here, as we do not yet know
> which version (if any) will contain the feature. Besides, we write our
> documentation to match the current version, so as long as this is 
> queued
> on top of the new code, I do not see any reason to mention a version 
> at
> all.

I'd included it because of the manual's title caveat "(for version 1.5.3 
or newer)", which I'd somehow thought was the matching date for the 
majority of text, hence my inclusion of the version. Begs the question 
what happened back then ;-)

>
> I'll tweak it while queueing.

Thank you.

>
> -Peff
> --

  reply	other threads:[~2012-10-25 22:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 21:34 [PATCH] Doc SubmittingPatches: Mention --notes option after "cover letter" Philip Oakley
2012-10-21 21:34 ` [PATCH] Doc User-Manual: Patch cover letter, three dashes, and --notes Philip Oakley
2012-10-25 10:26   ` Jeff King
2012-10-25 22:45     ` Philip Oakley [this message]
2012-10-21 21:34 ` [PATCH] Doc notes: Include the format-patch --notes option Philip Oakley
2012-10-21 21:34 ` [PATCH] Doc format-patch: clarify --notes use case Philip Oakley
2012-10-25 10:25   ` Jeff King
2012-10-25 22:48     ` Philip Oakley
2012-10-26 13:26       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F4D36C50EB6945CD8EB6E5AF73238148@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=eblake@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox