From: Lars Schneider <larsxschneider@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] perf: accommodate for MacOSX
Date: Tue, 21 Jun 2016 09:57:36 +0200 [thread overview]
Message-ID: <F67587B5-0EA8-4F2F-AADB-4343B4FEEA21@gmail.com> (raw)
In-Reply-To: <xmqqa8iftzex.fsf@gitster.mtv.corp.google.com>
> On 20 Jun 2016, at 21:48, Junio C Hamano <gitster@pobox.com> wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> On Sun, 19 Jun 2016, Lars Schneider wrote:
>>
>>>> On 18 Jun 2016, at 15:03, Johannes Schindelin
>>>> <johannes.schindelin@gmx.de> wrote:
>>>>
>>>> As this developer has no access to MacOSX developer setups anymore,
>>>> Travis becomes the best bet to run performance tests on that OS.
>>>
>>> We don't run the performance tests on Travis CI right now.
>>> Maybe we should? With your patch below it should work, right?
>> ...
>>
>> Yeah, well, I should have been clearer in my commit message: this patch
>> allows the perf tests to *run*, not to *pass*... ;-)
>
> OK, Lars, do we still want to take this patch? I am leaning towards
> taking it, if only to motivate interested others with OS X to look
> into making the perf tests to actually run.
I think we definitively should take the "perf-lib.sh" part of the patch
as this makes the perf test run on OSX and therefore is a strict
improvement.
If we don't run any perf tests by default on Travis CI then I wouldn't
take the ".travis.yml" part of the patch just to keep our Travis CI
setup as lean as possible. Running perf tests on Travis CI is probably
bogus anyways because we never know on what hardware our jobs run
and what other jobs run in parallel on that hardware.
- Lars
next prev parent reply other threads:[~2016-06-21 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 13:03 [PATCH] perf: accommodate for MacOSX Johannes Schindelin
2016-06-19 16:56 ` Lars Schneider
2016-06-20 6:45 ` Johannes Schindelin
2016-06-20 19:48 ` Junio C Hamano
2016-06-21 7:57 ` Lars Schneider [this message]
2016-06-21 11:55 ` Johannes Schindelin
2016-06-21 12:49 ` Lars Schneider
2016-06-21 13:50 ` Johannes Schindelin
2016-06-21 13:53 ` [PATCH v2] " Johannes Schindelin
2016-06-21 18:03 ` Lars Schneider
2016-06-21 18:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F67587B5-0EA8-4F2F-AADB-4343B4FEEA21@gmail.com \
--to=larsxschneider@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).