From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, ps@pks.im
Subject: Re: [GSoC PATCH v2 2/2] json-writer: describe the usage of jw_* functions
Date: Tue, 13 May 2025 19:22:26 -0300 [thread overview]
Message-ID: <F862E606-C784-433C-BAB1-283C678E20D5@gmail.com> (raw)
In-Reply-To: <CAOLa=ZQooC0TsjGG109MY_njoTm5GjW-WNf7-L2W6BN8umRL2Q@mail.gmail.com>
> Overall this looks good, but I do have to wonder if it is needed given
> that your previous patch already has documentation for each function.
Agreed, it looks like too much information. This second patch was
created after the review of v1, and to be honest, I think that this
overview is more clear as it focus in the what we want (write a JSON)
instead of documenting each function.
So, if I need to choose one of them, I'll choose this.
> But I'll leave that decision to you.
Ok, I'll keep the second!
> Thanks for working on this!
Thank you!
next prev parent reply other threads:[~2025-05-13 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 2:09 [GSoC PATCH v2 0/2] json-writer: describe the jw_* functions Lucas Seiki Oshiro
2025-05-12 2:09 ` [GSoC PATCH v2 1/2] json-writer: add docstrings to " Lucas Seiki Oshiro
2025-05-12 8:50 ` Patrick Steinhardt
2025-05-13 22:05 ` Lucas Seiki Oshiro
2025-05-14 2:41 ` Patrick Steinhardt
2025-05-12 9:36 ` Karthik Nayak
2025-05-12 2:09 ` [GSoC PATCH v2 2/2] json-writer: describe the usage of " Lucas Seiki Oshiro
2025-05-12 8:50 ` Patrick Steinhardt
2025-05-12 9:41 ` Karthik Nayak
2025-05-13 22:22 ` Lucas Seiki Oshiro [this message]
2025-05-14 2:40 ` Patrick Steinhardt
2025-05-12 8:49 ` [GSoC PATCH v2 0/2] json-writer: describe the " Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F862E606-C784-433C-BAB1-283C678E20D5@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).