From: Jeff Felchner <jfelchner1@gmail.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@talktalk.net>
Subject: Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column
Date: Sat, 26 May 2018 23:16:01 -0500 [thread overview]
Message-ID: <F8B7F3D0-E0C3-4E11-92EC-567BEDF19037@gmail.com> (raw)
In-Reply-To: <20180526210752.GA3094@zaya.teonanacatl.net>
Todd, it looks like that may very well be the same issue. And it looks like it's planning on being fixed in the next release? Would that be 2.17.1 since it's a regression?
> On 2018 May 26, at 16:07, Todd Zullinger <tmz@pobox.com> wrote:
>
> Hi Jeff,
>
> Jeff Felchner wrote:
>> Ever since 2.17.0, when saving a patch (using add --patch
>> but probably other ways as well), if the whitespace is
>> removed from the initial column, the patch doesn't apply.
>
> This sounds a bit like the issue discussed in this thread a
> few weeks ago:
>
> https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/
>
> But I didn't download or watch the video, so I'm not positive.
>
>> Full walkthrough (including comparison with 2.16.3) in the
>> video attached to this link:
>>
>> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1
>
> --
> Todd
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Everybody knows how to raise children, except the people who have
> them.
> -- P.J. O'Rourke
>
prev parent reply other threads:[~2018-05-27 4:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 20:45 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column Jeff Felchner
2018-05-26 21:07 ` Todd Zullinger
2018-05-27 4:16 ` Jeff Felchner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F8B7F3D0-E0C3-4E11-92EC-567BEDF19037@gmail.com \
--to=jfelchner1@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@talktalk.net \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox