git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thorsten Glaser <tg@mirbsd.de>
To: git@vger.kernel.org
Subject: Re: git should not use a default user.email config value
Date: Sat, 10 Aug 2013 12:06:08 +0000 (UTC)	[thread overview]
Message-ID: <Pine.BSM.4.64L.1308101202260.28970@herc.mirbsd.org> (raw)
In-Reply-To: <20130810102834.GA6237@sigill.intra.peff.net>

Jeff King dixit:

>It was not clear to me whether his site has /etc/mailname. If it does

Some may, some may not but…

>But from his description, the machine may even have a split-horizon name
>in /etc/mailname, and we can do nothing at all about that.

… that won’t happen. The problem is that they may have
the correct domain there but the localpart will still
be wrong because Kolab localparts are not Unix usernames.


Jonathan Nieder dixit:

>I thought that on other operating systems people typically don't have
>an /etc/mailname.  How does trusting the file when present hurt?

Right, MirBSD doesn’t have it, and I don’t think OpenBSD
added it since we forked.


Jeff King dixit:

>On Sat, Aug 10, 2013 at 11:59:21AM +0200, Michael Haggerty wrote:
>
>> I intentionally don't set user.email in my ~/.gitconfig because I use
>> different identities (on the same machine) depending on what project I

For me that’s also true, but I set a default one at the moment
which is still better than having an unroutable one (on my private
laptop, ${unix_username}@${fqdn} does work, but only as long as my
laptop is powered on, has got IPv6 Internet, and the sending MTA
has IPv6 Internet, so… it’s mostly unroutable).

While I used a fallback for this scenario (me, privately), I’d
also benefit from git refusing to accept commits by default.

>So if I understand your use case, then you would be even happier if
>rather than giving a warning, git simply barfed and said "please set
>your identity before committing"?

Exactly. That’s what I think he said, and what I asked for too.

Thanks,
//mirabilos (working with many OSS projects)
-- 
I believe no one can invent an algorithm. One just happens to hit upon it
when God enlightens him. Or only God invents algorithms, we merely copy them.
If you don't believe in God, just consider God as Nature if you won't deny
existence.		-- Coywolf Qi Hunt

  parent reply	other threads:[~2013-08-10 12:51 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130809134236.28143.75775.reportbug@tglase.lan.tarent.de>
2013-08-09 19:42 ` git should not use a default user.email config value Jonathan Nieder
2013-08-09 20:00   ` Thorsten Glaser
2013-08-09 20:30     ` Felipe Contreras
2013-08-13  8:29       ` Matthieu Moy
2013-08-09 22:37   ` Jeff King
2013-08-09 23:06     ` Junio C Hamano
2013-08-10  6:17       ` Jeff King
2013-08-10  6:40         ` Jonathan Nieder
2013-08-10  6:52           ` Jeff King
2013-08-10  7:03             ` Jonathan Nieder
2013-08-10  7:14               ` Jeff King
2013-08-09 23:19     ` Jonathan Nieder
2013-08-10  6:47       ` Jeff King
2013-08-10  9:59         ` Michael Haggerty
2013-08-10 10:28           ` Jeff King
2013-08-10 11:42             ` Michael Haggerty
2013-08-10 12:06             ` Thorsten Glaser [this message]
2013-08-10 12:34             ` Andreas Schwab
2013-08-12 12:51             ` Greg Troxel
2013-08-10 16:58           ` Junio C Hamano
2013-08-12 11:52             ` Andrew Ardill
2013-08-12 12:39               ` Jeff King
2013-08-12 12:54                 ` Michael Haggerty
2013-08-12 15:49                   ` Jeff King
2013-08-12 13:01                 ` Andrew Ardill
2013-08-12 15:45                   ` Jeff King
2013-08-13 11:05                     ` Andrew Ardill
2013-08-13 11:46                       ` Jeff King
2013-08-13 12:05                         ` Jeff King
2013-08-13 12:52                         ` Andrew Ardill
2013-08-13 15:53                           ` Jeff King
2013-08-13 16:33                         ` Junio C Hamano
2013-08-14  7:28                           ` Matthieu Moy
2013-08-14  7:40                             ` Jeff King
2013-08-14  8:37                               ` Matthieu Moy
2013-08-14 14:00                                 ` Junio C Hamano
2013-08-14 14:07                                   ` Matthieu Moy
2013-08-14 14:08                                   ` conditional config syntax Jeff King
2013-08-14 15:41                                     ` Junio C Hamano
2013-08-14  7:09                         ` git should not use a default user.email config value Michael Haggerty
2013-08-14  7:31                           ` Jeff King
2013-08-13 16:31                 ` Junio C Hamano
2013-08-13  8:08             ` Matthieu Moy
2013-08-11  0:06           ` Aaron Schrab
2013-08-13  8:24   ` Matthieu Moy
2013-08-13  8:39     ` Thorsten Glaser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.BSM.4.64L.1308101202260.28970@herc.mirbsd.org \
    --to=tg@mirbsd.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).