git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@uchicago.edu>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de
Subject: Why is 'map' used in filter-branch's skip_commit?
Date: Wed, 13 Aug 2008 16:16:27 -0500 (CDT)	[thread overview]
Message-ID: <Pine.GSO.4.62.0808131606020.11830@harper.uchicago.edu> (raw)

Hi,

I was wondering why skip_commit uses 'map' to rewrite the parents
supplied to the commit-filter.

For a moment, I was worried that if skip_commit has to rewrite parents
then the user should have to, too, before passing them to git
commit-tree - but no, it seems that the parents supplied to the
commit-filter are already rewritten.  In fact, before skip_commit was
introduced (commit f95eef), an example in the filter-branch
documentation used 'echo' instead of 'map' for the same construct.

Is it just a matter of style?  Or am I missing something else?

Thanks,

Jonathan

                 reply	other threads:[~2008-08-13 21:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.62.0808131606020.11830@harper.uchicago.edu \
    --to=jrnieder@uchicago.edu \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).