From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] Accept commit in some places when tree is needed.
Date: Wed, 20 Apr 2005 08:32:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0504200826360.6467@ppc970.osdl.org> (raw)
In-Reply-To: <7vis2ikmj0.fsf@assigned-by-dhcp.cox.net>
On Tue, 19 Apr 2005, Junio C Hamano wrote:
>
> This patch lifts the tree-from-tree-or-commit logic from
> diff-cache.c and moves it to sha1_file.c, which is a common
> library source for the SHA1 storage part.
I don't think that's a good interface. It changes the sha1 passed into it:
that may actually be nice, since you may want to know what it changed to,
but I think you'd want to have that as an (optional) separate
"sha1_result" parameter.
Also, the "type" or "size" things make no sense to have as a parameter
at all.
IOW, it was fine when it was an internal hacky thing in diff-cache, but
once it's promoted to be a real library function it should definitely be
cleaned up to have sane interfaces that make sense in general, and not
just within the original context.
Linus
next prev parent reply other threads:[~2005-04-20 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 6:08 [PATCH 1/4] Accept commit in some places when tree is needed Junio C Hamano
2005-04-20 6:35 ` (fixed) " Junio C Hamano
2005-04-20 15:32 ` Linus Torvalds [this message]
2005-04-21 0:19 ` (rework) [PATCH 1/5] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0504200826360.6467@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).