git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
Cc: Sean <seanlkml@sympatico.ca>, Sam Ravnborg <sam@ravnborg.org>,
	git@vger.kernel.org
Subject: Re: cogito - how do I ???
Date: Mon, 23 May 2005 07:35:47 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0505230731430.2307@ppc970.osdl.org> (raw)
In-Reply-To: <20050523071919.GG23388@cip.informatik.uni-erlangen.de>



On Mon, 23 May 2005, Thomas Glanzmann wrote:
> 
> > 	git-rev-tree MERGE_HEAD ^HEAD | git-diff-tree -v -m -s --stdin
> 
> This doesn't work for me:

Yeah, I'm an idiot.

> Bit this does:
> 
> (faui00u) [~/work/git/git] git-rev-tree 2cb45e95438c113871fbbea5b4f629f9463034e7 ^09d74b3b5ac634495e17b92b2b785fa996ffce97 | awk '{print $2'} | sed 's#:.*##' | git-diff-tree -v -m -s --stdin
> 
> was that a typo or is git-diff-tree supposed to handle the output of
> git-rev-tree as well and it is a bug?

It was me just forgetting about the time thing in rev-tree, forcing you to
have a second phase there (I usually use just "cut -d' ' -f2" - the input
_can_ have the ":n" flag thing that rev-tree outputs, and git-diff-tree
will just ignore it).

I actually suspect that whole time thing was a mistake, it seemed sensible 
back when we didn't have any other way of ordering the changesets well, 
but it's really a bad ordering anyway to do it by time (ie add a "sort 
-rn" in there), and we can (and probably should) order rev-tree output 
with some topological sort based on the commit tree.

		Linus

  parent reply	other threads:[~2005-05-23 14:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-21 21:47 cogito - how do I ??? Sam Ravnborg
2005-05-21 22:06 ` Sean
2005-05-21 23:41   ` Linus Torvalds
2005-05-22  7:14     ` Sam Ravnborg
2005-05-22 16:23       ` Linus Torvalds
2005-05-23  7:19     ` Thomas Glanzmann
2005-05-23  7:40       ` Junio C Hamano
2005-05-23  8:02         ` Thomas Glanzmann
2005-05-23 14:35       ` Linus Torvalds [this message]
2005-05-23 16:34         ` Junio C Hamano
2005-05-24  2:26         ` Herbert Xu
2005-05-24  3:05           ` Linus Torvalds
2005-05-22  5:27   ` Frank Sorenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0505230731430.2307@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=seanlkml@sympatico.ca \
    --cc=sithglan@stud.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).