git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make sure diff-helper can tell rename/copy in the new diff-raw format.
Date: Mon, 23 May 2005 12:16:02 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0505231210420.2307@ppc970.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0505231156210.2307@ppc970.osdl.org>



On Mon, 23 May 2005, Linus Torvalds wrote:
> 
> because having it there makes it just easier to parse, and means that we 
> can add "reasons" later without having to worry about ambiguities with 
> filenames.

Btw, putting the "what happened" into the fixed-format stuff before the
filenames allows you to have more thana fixed number of filenames even in
the machine-readable format. For example, it would allow the
machine-readable format to have just a single NUL character at the end of
the line for the "modified" case, since now it's unambigious where the
line ends (thanks to the fact that "M" always has only one file).

Similarly, it allows us to later add a "combine" reason (take two files, 
combine them into a third), which needs three filenames. That would 
becomes very messy if the "reason" part is after the filenames, because it 
gets easily ambigious.

		Linus

  reply	other threads:[~2005-05-23 19:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23  7:26 [PATCH] Make sure diff-helper can tell rename/copy in the new diff-raw format Junio C Hamano
2005-05-23 14:49 ` Linus Torvalds
2005-05-23 18:43   ` Junio C Hamano
2005-05-23 19:03     ` Linus Torvalds
2005-05-23 19:16       ` Linus Torvalds [this message]
2005-05-23 21:55       ` [PATCH] diff-raw format update take #2 Junio C Hamano
2005-05-23 22:08         ` Junio C Hamano
2005-05-24  0:12         ` Chris Wedgwood
2005-05-24  0:25           ` Junio C Hamano
2005-05-24  0:31             ` Chris Wedgwood
2005-05-24  0:45               ` Junio C Hamano
2005-05-24  1:03                 ` Linus Torvalds
2005-05-24  1:05                   ` Chris Wedgwood
2005-05-24  1:29                   ` David Lang
2005-05-24  1:33                     ` Chris Wedgwood
2005-05-24  1:39                       ` Thomas Glanzmann
     [not found]                         ` <20050524013947.ADFEE528F53@taniwha.stupidest.org>
2005-05-24  1:44                           ` Thomas Glanzmann
2005-05-24  1:50                       ` Linus Torvalds
2005-05-24  0:51               ` Linus Torvalds
2005-05-26  0:55   ` [PATCH] Make sure diff-helper can tell rename/copy in the new diff-raw format Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0505231210420.2307@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).