From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Subject: Re: [PATCH] add a diff-files command
Date: Thu, 28 Apr 2005 12:56:43 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.62.0504281238130.14033@localhost.localdomain> (raw)
In-Reply-To: <7vr7gu97xq.fsf@assigned-by-dhcp.cox.net>
On Thu, 28 Apr 2005, Junio C Hamano wrote:
> If you want to see if working tree has some junk other than
> those listed in dontdiff, wouldn't this be sufficient?
>
> $ show-files --others | grep -f dontdiff
Well, it would work if the dontdiff file other people are maintaining
was made up of regexps. But it is made of shell wildcard patterns meant
to be used with the -X switch of the diff command.
> Again, "checking for potentially uncommitted" files is what
> you use show-files --others for, not show-diff.
Indeed. And yesterday I realized that the (currently unimplemented)
--ignore switch to show-files, combined with the exclusion pattern list,
whould be more logical than teaching show-diff (which I still think is a
misnamer in the context of the other diff tools) about files unknown to
the cache. The patch to show-files is also much smaller and logical.
BTW, I don't do this out of pure entousiasm but rather trying to make my
own workflow with the Linux kernel source tree more efficient in the
context of git usage. My pure coding entousiasm lies somewhere else.
Nicolas
next prev parent reply other threads:[~2005-04-28 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 21:13 [PATCH] add a diff-files command Nicolas Pitre
2005-04-27 21:49 ` Junio C Hamano
2005-04-28 1:02 ` Nicolas Pitre
2005-04-28 16:34 ` Junio C Hamano
2005-04-28 16:56 ` Nicolas Pitre [this message]
2005-04-28 17:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0504281238130.14033@localhost.localdomain \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).