* BEWARE: mkdelta is broken
@ 2005-05-27 1:32 Nicolas Pitre
2005-05-27 9:41 ` Thomas Glanzmann
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Pitre @ 2005-05-27 1:32 UTC (permalink / raw)
To: git
Please don't use mkdelta on a valuable repository for the time being.
The current delta loop detection logic is broken. So if you have
multiple merged branches or you have a changeset that revert things then
you might end up with a delta loop and fsck-cache will effectively
complain about unresolved deltas and assorted dangling/broken object
links.
I'm working on a fix right now.
Nicolas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: BEWARE: mkdelta is broken
2005-05-27 1:32 BEWARE: mkdelta is broken Nicolas Pitre
@ 2005-05-27 9:41 ` Thomas Glanzmann
2005-05-27 17:37 ` Nicolas Pitre
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Glanzmann @ 2005-05-27 9:41 UTC (permalink / raw)
To: git
Hello,
> The current delta loop detection logic is broken. So if you have
> multiple merged branches or you have a changeset that revert things then
> you might end up with a delta loop and fsck-cache will effectively
> complain about unresolved deltas and assorted dangling/broken object
> links.
I wanted to give you heads-up, but I forgot it. But I think noone is
using it at the moment otherwise they had complained in the first place.
However ... I took linux-2.6 repository. Ran git-deltafy-script &&
git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs
import.
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: BEWARE: mkdelta is broken
2005-05-27 9:41 ` Thomas Glanzmann
@ 2005-05-27 17:37 ` Nicolas Pitre
2005-05-27 17:42 ` Thomas Glanzmann
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Pitre @ 2005-05-27 17:37 UTC (permalink / raw)
To: Thomas Glanzmann; +Cc: git
On Fri, 27 May 2005, Thomas Glanzmann wrote:
> Hello,
>
> > The current delta loop detection logic is broken. So if you have
> > multiple merged branches or you have a changeset that revert things then
> > you might end up with a delta loop and fsck-cache will effectively
> > complain about unresolved deltas and assorted dangling/broken object
> > links.
>
> I wanted to give you heads-up, but I forgot it. But I think noone is
> using it at the moment otherwise they had complained in the first place.
>
> However ... I took linux-2.6 repository. Ran git-deltafy-script &&
> git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs
> import.
Yes, that's because you end up with delta loops. When trying to expand
the delta, it keeps looping and allocating memory until killed.
I fixed that already and am preparing a patch at the moment.
Nicolas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-05-27 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-27 1:32 BEWARE: mkdelta is broken Nicolas Pitre
2005-05-27 9:41 ` Thomas Glanzmann
2005-05-27 17:37 ` Nicolas Pitre
2005-05-27 17:42 ` Thomas Glanzmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).