Re: BEWARE: mkdelta is broken

[Nicolas Pitre <nico@cam.org>]

On Fri, 27 May 2005, Thomas Glanzmann wrote:

> Hello,
> 
> > The current delta loop detection logic is broken.  So if you have 
> > multiple merged branches or you have a changeset that revert things then 
> > you might end up with a delta loop and fsck-cache will effectively 
> > complain about unresolved deltas and assorted dangling/broken object 
> > links.
> 
> I wanted to give you heads-up, but I forgot it. But I think noone is
> using it at the moment otherwise they had complained in the first place.
> 
> However ... I took linux-2.6 repository. Ran git-deltafy-script &&
> git-deltafy-script -d 0 and it segfaulted on me. Same for my mutt-cvs
> import.

Yes, that's because you end up with delta loops.  When trying to expand 
the delta, it keeps looping and allocating memory until killed.

I fixed that already and am preparing a patch at the moment.


Nicolas