From: Daniel Barkalow <barkalow@iabervon.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Do not send "want" lines for complete objects
Date: Thu, 20 Oct 2005 16:32:08 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0510201630000.25300@iabervon.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0510200559540.3394@wbgn013.biozentrum.uni-wuerzburg.de>
On Thu, 20 Oct 2005, Johannes Schindelin wrote:
> Hi,
>
> > > + ((o = parse_object(remote)) != NULL) &&
> > > + (o->flags & COMPLETE) &&
>
> I just realized that parse_object() always reads the file, then does a
> lookup (which makes the above code work), and then parses the file. It
> always does all of these steps, even if the object was already parsed. Any
> reason for this?
I'm lazy and haven't sent in a patch to clean that up. There's no reason
it couldn't check whether the value it gets is already parsed.
-Daniel
*This .sig left intentionally blank*
next prev parent reply other threads:[~2005-10-20 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 22:07 [PATCH] Do not send "want" lines for complete objects Johannes Schindelin
2005-10-19 23:09 ` Junio C Hamano
2005-10-20 1:16 ` Junio C Hamano
2005-10-20 2:04 ` Johannes Schindelin
2005-10-20 4:08 ` Johannes Schindelin
2005-10-20 4:16 ` Junio C Hamano
2005-10-20 20:32 ` Daniel Barkalow [this message]
2005-10-20 23:16 ` Johannes Schindelin
2005-10-21 0:43 ` Junio C Hamano
2005-10-21 15:44 ` Daniel Barkalow
2005-10-20 1:51 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0510201630000.25300@iabervon.org \
--to=barkalow@iabervon.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox