From: Linus Torvalds <torvalds@osdl.org>
To: John Ellson <ellson@research.att.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make GIT-VERSION-GEN tolerate missing git describe command
Date: Fri, 30 Dec 2005 11:55:32 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0512301153100.3249@g5.osdl.org> (raw)
In-Reply-To: <43B586B4.5030001@research.att.com>
On Fri, 30 Dec 2005, John Ellson wrote:
>
> I checked and that bug has been fixed since the older version of git that
> was causing me problems. "git non_existent_command" now returns 1.
Ahh, good.
> However, the error message was also changed to goto stderr, which it
> sounds like you disagree with?
Not that I can see:
[torvalds@g5 ~]$ git --version
git version 1.0.6-g58e3
[torvalds@g5 ~]$ git hjsdhjas > /dev/null
[torvalds@g5 ~]$ echo $?
1
so yes, it returns a proper error, and it outputs the help message to
stdout, not stderr. Which is fine, because it means that you can indeed do
git help | less
and it will do the right thing (apart from printing the line
git: 'help' is not a git-command
which is a bit sad).
Linus
next prev parent reply other threads:[~2005-12-30 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-30 16:23 [PATCH] Make GIT-VERSION-GEN tolerate missing git describe command John Ellson
2005-12-30 18:49 ` Linus Torvalds
2005-12-30 19:12 ` John Ellson
2005-12-30 19:55 ` Linus Torvalds [this message]
2005-12-30 19:31 ` John Ellson
2005-12-31 0:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0512301153100.3249@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=ellson@research.att.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).