From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Darrin Thompson <darrint@progeny.com>
Subject: Re: [PATCH 2/3] ls-files --others --directory: give trailing slash
Date: Sat, 7 Jan 2006 15:35:08 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601071533060.3169@g5.osdl.org> (raw)
In-Reply-To: <7vy81racv7.fsf@assigned-by-dhcp.cox.net>
On Sat, 7 Jan 2006, Junio C Hamano wrote:
>
> * Likes, dislikes? This suits better for *my* purpose of
> calling this from git-status, but it might be undesirable for
> your Porcelain.
Likes.
However, I'd re-write it as just
memcpy(fullname + baselen + len, "/", 2);
len++;
if (show_other_directories &&
!dir_exists(fullname, baselen + len))
break;
read_directory(fullname, fullname, baselen + len);
because let's face it, every user wants the "+1", so just do it once
up-front instead of adding one in three different places.
Linus
next prev parent reply other threads:[~2006-01-07 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-07 22:31 [PATCH 2/3] ls-files --others --directory: give trailing slash Junio C Hamano
2006-01-07 23:35 ` Linus Torvalds [this message]
2006-01-09 15:17 ` Darrin Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601071533060.3169@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=darrint@progeny.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).