From: Linus Torvalds <torvalds@osdl.org>
To: Andreas Ericsson <ae@op5.se>
Cc: Timo Hirvonen <tihirvon@gmail.com>, git@vger.kernel.org
Subject: Re: git-format-patch Date header
Date: Sun, 8 Jan 2006 22:11:19 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0601082207510.3169@g5.osdl.org> (raw)
In-Reply-To: <43C12DE9.8010906@op5.se>
On Sun, 8 Jan 2006, Andreas Ericsson wrote:
>
> Actually, that's what's printed in the commit message, so any change
> would have to be put there and that would break backwards compatibility
> for new tools that might want to use it.
No, git should always take the date in any of a million different formats,
and always turn it into "seconds + timezone" internally.
The fact that git-format-patch also prints it out in the internal format
is unambiguous (nice) but human-unreadable (bad).
There are other unambiguous formats it could use, notably standard rfc2822
format ("date -R").
The git "show_date()" function hopefully does exactly that rfc2822 format,
but you'd have to make a helper program to do the conversion in
git-format-patch.sh.
Linus
next prev parent reply other threads:[~2006-01-09 6:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 14:15 [PATCH] .gitignore git-describe Andreas Ericsson
2006-01-08 14:40 ` git-format-patch Date header Timo Hirvonen
2006-01-08 15:21 ` Andreas Ericsson
2006-01-08 15:37 ` Timo Hirvonen
2006-01-08 15:44 ` Andreas Ericsson
2006-01-08 22:05 ` H. Peter Anvin
2006-01-08 23:30 ` Andreas Ericsson
2006-01-09 6:11 ` Linus Torvalds [this message]
2006-01-08 14:01 ` [PATCH] format-patch: Use --mbox by default Andreas Ericsson
2006-01-08 20:28 ` Junio C Hamano
2006-01-09 2:01 ` Andreas Ericsson
2006-01-08 22:14 ` H. Peter Anvin
2006-01-09 2:05 ` Andreas Ericsson
2006-01-13 23:56 ` [PATCH] format-patch: always --mbox and show sane Date: Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0601082207510.3169@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=tihirvon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).